diff options
| author | Vidhin Mehta (OpenERP) <vme@tinyerp.com> | 2011-08-23 14:31:21 +0530 |
|---|---|---|
| committer | Vidhin Mehta (OpenERP) <vme@tinyerp.com> | 2011-08-23 14:31:21 +0530 |
| commit | a97bb0476ca74b2fa43bc58d408b68d78477610e (patch) | |
| tree | f198d23a29c7afddd02f6eb6e699b7a0f1bad536 /addons/base/static/src/js | |
| parent | 71b057aa3402346ccfc4364d20a81a96b5e632f8 (diff) | |
[fix]Optimize code in add event
bzr revid: vme@tinyerp.com-20110823090121-gk2iayz1eavjwdfg
Diffstat (limited to 'addons/base/static/src/js')
| -rw-r--r-- | addons/base/static/src/js/chrome.js | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/addons/base/static/src/js/chrome.js b/addons/base/static/src/js/chrome.js index ec666cf8c8a..ef8779152bc 100644 --- a/addons/base/static/src/js/chrome.js +++ b/addons/base/static/src/js/chrome.js @@ -585,28 +585,26 @@ openerp.base.Header = openerp.base.Widget.extend({ $(sc.binding).bind({ 'add': function (e, attrs) { shortcuts_ds.create(attrs, function (out) { - var $shortcut = $('<li>', { - 'data-shortcut-id':out.result, - 'data-id': attrs.res_id + $('<li>', { + 'data-shortcut-id':out.result, + 'data-id': attrs.res_id }).text(attrs.name) .appendTo(self.$element.find('.oe-shortcuts ul')); attrs.id = out.result; - sc.splice(sc.lenght,0,attrs); - sc.push.apply(sc); + sc.push(attrs); }); - - }, + }, 'remove-current': function () { var menu_id = self.session.active_id; var $shortcut = self.$element - .find('.oe-shortcuts li[data-id=' + menu_id + ']'); + .find('.oe-shortcuts li[data-id=' + menu_id + ']'); var shortcut_id = $shortcut.data('shortcut-id'); $shortcut.remove(); shortcuts_ds.unlink([shortcut_id]); - sc1 = _.reject(sc, function(shortcut){ return shortcut_id === shortcut.id}); + var sc_new = _.reject(sc, function(shortcut){ return shortcut_id === shortcut.id}); sc.splice(0, sc.length); - sc.push.apply(sc ,sc1); - } + sc.push.apply(sc,sc_new); + } }); } return this.rpc('/base/session/sc_list', {}, function(shortcuts) { |