diff options
| author | Swapnesh Shah <swapneshshah111@gmail.com> | 2020-01-26 16:55:55 +0000 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2020-02-17 20:24:25 +0000 |
| commit | 695a1c8adab65fd02213842c592ad805c2efec8d (patch) | |
| tree | 30d7972fc8479183f0445797a71fd7e46c7bfdad /addons/auth_oauth | |
| parent | 98d5770e5da3064243d24fce95440d0c03cf7080 (diff) | |
[FIX] auth_oauth: set values when necessary
If the record with the external id 'auth_oauth.provider_google' does
not exist in the database, 'google_provider' variable will contains
None.
Before this commit, calling get and set methods produced an error.
After this commit, trying to set a token for Google Authentication
will do nothing.
While this is not ideal, one can assume somebody that deleted an OAuth
provider rarely wants to configure it and can still upgrade the module
to get it back.
closes odoo/odoo#45566
X-original-commit: eca90a31d0d3667cf63994d34c5d2bb81bfd45c4
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Diffstat (limited to 'addons/auth_oauth')
| -rw-r--r-- | addons/auth_oauth/models/res_config_settings.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/auth_oauth/models/res_config_settings.py b/addons/auth_oauth/models/res_config_settings.py index 43de10ebbd6..0c20ab6613f 100644 --- a/addons/auth_oauth/models/res_config_settings.py +++ b/addons/auth_oauth/models/res_config_settings.py @@ -23,7 +23,7 @@ class ResConfigSettings(models.TransientModel): def get_values(self): res = super(ResConfigSettings, self).get_values() google_provider = self.env.ref('auth_oauth.provider_google', False) - res.update( + google_provider and res.update( auth_oauth_google_enabled=google_provider.enabled, auth_oauth_google_client_id=google_provider.client_id, server_uri_google=self.get_uri(), @@ -33,7 +33,7 @@ class ResConfigSettings(models.TransientModel): def set_values(self): super(ResConfigSettings, self).set_values() google_provider = self.env.ref('auth_oauth.provider_google', False) - google_provider.write({ + google_provider and google_provider.write({ 'enabled': self.auth_oauth_google_enabled, 'client_id': self.auth_oauth_google_client_id, }) |