summaryrefslogtreecommitdiff
path: root/addons/auth_crypt
diff options
context:
space:
mode:
authorOlivier Dony <odo@openerp.com>2015-07-29 13:48:12 +0200
committerOlivier Dony <odo@openerp.com>2015-07-29 13:49:11 +0200
commitb4de311b0c04d9ac4e576a7d72e47fe48ca5e405 (patch)
treee77472fe90a91a67eb7fa72684db259ef799c8d2 /addons/auth_crypt
parent93f5f86afd3e92f2e9b5559355e94982de45c43a (diff)
[FIX] auth_crypt: use system random number generator
Switch to system random as number generator instead of the default PRNG, which is not recommended for generating security-related values such as unique tokens. (Complements parent commit) Closes #7761
Diffstat (limited to 'addons/auth_crypt')
-rw-r--r--addons/auth_crypt/auth_crypt.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/auth_crypt/auth_crypt.py b/addons/auth_crypt/auth_crypt.py
index 9724b511a05..3aac70c1a59 100644
--- a/addons/auth_crypt/auth_crypt.py
+++ b/addons/auth_crypt/auth_crypt.py
@@ -11,7 +11,7 @@
import hashlib
import hmac
import logging
-from random import sample
+import random
from string import ascii_letters, digits
import openerp
@@ -28,7 +28,7 @@ res_users.USER_PRIVATE_FIELDS.append('password_crypt')
def gen_salt(length=8, symbols=None):
if symbols is None:
symbols = ascii_letters + digits
- return ''.join(sample(symbols, length))
+ return ''.join(random.SystemRandom().sample(symbols, length))
def md5crypt( raw_pw, salt, magic=magic_md5 ):
""" md5crypt FreeBSD crypt(3) based on but different from md5