diff options
| author | Goffin Simon <sig@odoo.com> | 2020-12-10 14:09:02 +0000 |
|---|---|---|
| committer | Goffin Simon <sig@odoo.com> | 2020-12-10 14:18:08 +0000 |
| commit | f01eb942716800921148b5de8d6bc4140d122912 (patch) | |
| tree | 3b5a40e12a0b26cb5e46f458ef88f036df589f20 /addons/account_check_printing/models | |
| parent | a0c7880c0bd25fc8c5dd23755acc59966c62cbf9 (diff) | |
[FIX] account_check_printing: Check number in Payment
Steps to reproduce the bug:
- Let's consider a bank journal BJ with manual numbering activated
- Create a customer payment CP using BJ as journal and confirm CP
- Create a vendor payment VP using BJ as journal, select Check as payment method
- A Check Number with 0001 is automatically assigned to VP
- Confirm or save VP
Bug:
An error was raised saying that:
The following numbers are already used: 0001
PS: When creating the customer payment, a check number was assigned to CP even if
customer payment has nothing to do with check numbers
opw:2415170
closes odoo/odoo#63174
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Diffstat (limited to 'addons/account_check_printing/models')
| -rw-r--r-- | addons/account_check_printing/models/account_payment.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/addons/account_check_printing/models/account_payment.py b/addons/account_check_printing/models/account_payment.py index 215af3ef922..61e0e66211f 100644 --- a/addons/account_check_printing/models/account_payment.py +++ b/addons/account_check_printing/models/account_payment.py @@ -21,6 +21,7 @@ class AccountPayment(models.Model): string="Check Number", store=True, readonly=True, + copy=False, compute='_compute_check_number', inverse='_inverse_check_number', help="The selected journal is configured to print check numbers. If your pre-printed check paper already has numbers " @@ -47,6 +48,8 @@ class AccountPayment(models.Model): AND move.journal_id = other_move.journal_id AND payment.id != other_payment.id AND payment.id IN %(ids)s + AND move.state = 'posted' + AND other_move.state = 'posted' """, { 'ids': tuple(self.ids), }) @@ -69,10 +72,10 @@ class AccountPayment(models.Model): else: pay.check_amount_in_words = False - @api.depends('journal_id') + @api.depends('journal_id', 'payment_method_code') def _compute_check_number(self): for pay in self: - if pay.journal_id.check_manual_sequencing: + if pay.journal_id.check_manual_sequencing and pay.payment_method_code == 'check_printing': sequence = pay.journal_id.check_sequence_id pay.check_number = sequence.get_next_char(sequence.number_next_actual) else: |