[FIX] account: Fix missing constrains about multi-companies.

There is actually nothing preventing changing the company of some records even
there is some journal entries/items that are using them.

closes odoo/odoo#41945

X-original-commit: b3b66304eb98819cd87d6e4c7a29ca4803ffc3ff
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

2 files changed, 106 insertions, 2 deletions

diff --git a/addons/account/models/account.py b/addons/account/models/account.py
index 524efd3adc6..f335bd66354 100644
--- a/addons/account/models/account.py
+++ b/addons/account/models/account.py
@@ -406,6 +406,22 @@ class AccountAccount(models.Model):
         if ids:
             raise ValidationError(_('Some journal items already exist with this account but in other journals than the allowed ones.'))
 
+    @api.constrains('company_id')
+    def _check_company_consistency(self):
+        if not self:
+            return
+
+        self.flush(['company_id'])
+        self._cr.execute('''
+            SELECT line.id
+            FROM account_move_line line
+            JOIN account_account account ON account.id = line.account_id
+            WHERE line.account_id IN %s
+            AND line.company_id != account.company_id
+        ''', [tuple(self.ids)])
+        if self._cr.fetchone():
+            raise UserError(_("You can't change the company of your account since there are some journal items linked to it."))
+
     @api.depends('code')
     def _compute_account_root(self):
         # this computes the first 2 digits of the account.
@@ -1059,6 +1075,22 @@ class AccountJournal(models.Model):
                 if journal.bank_account_id.partner_id != journal.company_id.partner_id:
                     raise ValidationError(_('The holder of a journal\'s bank account must be the company (%s).') % journal.company_id.name)
 
+    @api.constrains('company_id')
+    def _check_company_consistency(self):
+        if not self:
+            return
+
+        self.flush(['company_id'])
+        self._cr.execute('''
+            SELECT move.id
+            FROM account_move move
+            JOIN account_journal journal ON journal.id = move.journal_id
+            WHERE move.journal_id IN %s
+            AND move.company_id != journal.company_id
+        ''', [tuple(self.ids)])
+        if self._cr.fetchone():
+            raise UserError(_("You can't change the company of your journal since there are some journal entries linked to it."))
+
     @api.onchange('default_debit_account_id')
     def onchange_debit_account_id(self):
         if not self.default_credit_account_id:
@@ -1541,7 +1573,32 @@ class AccountTax(models.Model):
             if not tax._check_m2m_recursion('children_tax_ids'):
                 raise ValidationError(_("Recursion found for tax '%s'.") % (tax.name,))
             if not all(child.type_tax_use in ('none', tax.type_tax_use) for child in tax.children_tax_ids):
-                raise ValidationError(_('The application scope of taxes in a group must be either the same as the group or left empty.'))
+                raise ValidationError(_('The application scope of taxes in a group must be either the same as the group or left empty.'))\
+
+    @api.constrains('company_id')
+    def _check_company_consistency(self):
+        if not self:
+            return
+
+        self.flush(['company_id'])
+        self._cr.execute('''
+            SELECT line.id
+            FROM account_move_line line
+            JOIN account_tax tax ON tax.id = line.tax_line_id
+            WHERE line.tax_line_id IN %s
+            AND line.company_id != tax.company_id
+            
+            UNION ALL
+            
+            SELECT line.id
+            FROM account_move_line_account_tax_rel tax_rel
+            JOIN account_tax tax ON tax.id = tax_rel.account_tax_id
+            JOIN account_move_line line ON line.id = tax_rel.account_move_line_id
+            WHERE tax_rel.account_tax_id IN %s
+            AND line.company_id != tax.company_id
+        ''', [tuple(self.ids)] * 2)
+        if self._cr.fetchone():
+            raise UserError(_("You can't change the company of your tax since there are some journal items linked to it."))
 
     @api.returns('self', lambda value: value.id)
     def copy(self, default=None):
diff --git a/addons/account/models/account_analytic_line.py b/addons/account/models/account_analytic_line.py
index 60e80ab015a..3b02d93e5b2 100644
--- a/addons/account/models/account_analytic_line.py
+++ b/addons/account/models/account_analytic_line.py
@@ -1,7 +1,54 @@
 # -*- coding: utf-8 -*-
 
 from odoo import api, fields, models, _
-from math import copysign
+from odoo.exceptions import UserError
+
+
+class AccountAnalyticAccount(models.Model):
+    _inherit = 'account.analytic.account'
+
+    @api.constrains('company_id')
+    def _check_company_consistency(self):
+        analytic_accounts = self.filtered('company_id')
+
+        if not analytic_accounts:
+            return
+
+        self.flush(['company_id'])
+        self._cr.execute('''
+            SELECT line.id
+            FROM account_move_line line
+            JOIN account_analytic_account account ON account.id = line.analytic_account_id
+            WHERE line.analytic_account_id IN %s
+            AND line.company_id != account.company_id
+        ''', [tuple(analytic_accounts.ids)])
+
+        if self._cr.fetchone():
+            raise UserError(_("You can't set a different company on your analytic account since there are some journal items linked to it."))
+
+
+class AccountAnalyticTag(models.Model):
+    _inherit = 'account.analytic.tag'
+
+    @api.constrains('company_id')
+    def _check_company_consistency(self):
+        analytic_tags = self.filtered('company_id')
+
+        if not analytic_tags:
+            return
+
+        self.flush(['company_id'])
+        self._cr.execute('''
+            SELECT line.id
+            FROM account_analytic_tag_account_move_line_rel tag_rel
+            JOIN account_analytic_tag tag ON tag.id = tag_rel.account_analytic_tag_id
+            JOIN account_move_line line ON line.id = tag_rel.account_move_line_id
+            WHERE tag_rel.account_analytic_tag_id IN %s
+            AND line.company_id != tag.company_id
+        ''', [tuple(analytic_tags.ids)])
+
+        if self._cr.fetchone():
+            raise UserError(_("You can't set a different company on your analytic tags since there are some journal items linked to it."))
 
 
 class AccountAnalyticLine(models.Model):