summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristophe Simonis <chs@odoo.com>2019-06-24 14:48:54 +0200
committerChristophe Simonis <chs@odoo.com>2019-06-24 14:48:54 +0200
commitfbd874368a30c1665ca1410046b60cf1dd8ce31d (patch)
tree423344000456555d083d4b5199791b2b63a0d506
parent08629638770932800ed7a86c5211c3760024d2c9 (diff)
[FIX] website_sale_comparison: correct product removal from comparison list
Oversight of previous forward-port.
-rw-r--r--addons/website_sale_comparison/static/src/js/website_sale_comparison.js11
1 files changed, 7 insertions, 4 deletions
diff --git a/addons/website_sale_comparison/static/src/js/website_sale_comparison.js b/addons/website_sale_comparison/static/src/js/website_sale_comparison.js
index 48eb44494c4..f701374b350 100644
--- a/addons/website_sale_comparison/static/src/js/website_sale_comparison.js
+++ b/addons/website_sale_comparison/static/src/js/website_sale_comparison.js
@@ -65,8 +65,10 @@ var ProductComparison = publicWidget.Widget.extend(VariantMixin, {
});
$(document.body).on('click.product_comparaison_widget', '.o_comparelist_remove', function (ev) {
self._removeFromComparelist(ev);
- var new_link = '/shop/compare/?products=' + self.comparelist_product_ids.toString();
- window.location.href = _.isEmpty(self.comparelist_product_ids) ? '/shop' : new_link;
+ self.guard.exec(function() {
+ var new_link = '/shop/compare/?products=' + self.comparelist_product_ids.toString();
+ window.location.href = _.isEmpty(self.comparelist_product_ids) ? '/shop' : new_link;
+ });
});
return this._super.apply(this, arguments);
@@ -198,8 +200,9 @@ var ProductComparison = publicWidget.Widget.extend(VariantMixin, {
this.guard.exec(this._removeFromComparelistImpl.bind(this, e));
},
_removeFromComparelistImpl: function (e) {
- this.comparelist_product_ids = _.without(this.comparelist_product_ids, $(e.currentTarget).data('product_product_id'));
- $(e.currentTarget).parents('.o_product_row').remove();
+ var target = $(e.target.closest('.o_comparelist_remove, .o_remove'));
+ this.comparelist_product_ids = _.without(this.comparelist_product_ids, target.data('product_product_id'));
+ target.parents('.o_product_row').remove();
this._updateCookie();
$('.o_comparelist_limit_warning').hide();
this._updateContent('show');