summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThibault Delavallée <tde@odoo.com>2018-07-18 11:08:44 +0200
committerThibault Delavallée <tde@odoo.com>2018-07-19 17:05:20 +0200
commitdd72fef73f8fbe8f152866abb99badbb34ae06e2 (patch)
tree1257dcf4b6b82105d155a63ade45b3ac6833e4ca
parent49f634e47261c663955f4ccf432cbff4a02c349f (diff)
[IMP] base: do not format email for partners not having email
Currently if a partner has a void email, its email_formatted field holds a value like "Raoul Grosbedon <False>" which is quite rarely considered as a valid email address. Minimal fix for this field is to return a void value if there is no email. Having a void return is easier to manipulate for callers in order to handle it. This commit is linked to task ID 1860049 and PR #25824.
-rw-r--r--odoo/addons/base/models/res_partner.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py
index a477befcd24..0efcc576da2 100644
--- a/odoo/addons/base/models/res_partner.py
+++ b/odoo/addons/base/models/res_partner.py
@@ -374,7 +374,10 @@ class Partner(models.Model):
@api.depends('name', 'email')
def _compute_email_formatted(self):
for partner in self:
- partner.email_formatted = formataddr((partner.name or u"False", partner.email or u"False"))
+ if partner.email:
+ partner.email_formatted = formataddr((partner.name or u"False", partner.email or u"False"))
+ else:
+ partner.email_formatted = ''
@api.depends('is_company')
def _compute_company_type(self):