summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Bohy <aab@odoo.com>2017-03-21 22:30:11 +0100
committerAaron Bohy <aab@odoo.com>2017-04-11 19:44:38 +0200
commitd75a7b850a7e6db7db238f7fe1404d717d4ffd67 (patch)
treea92bb7fa444362a016800bde5d3a4a007147e059
parentfc08507fdb9d1aab08e60c81a698e203b9b819a2 (diff)
[FIX] web: Kanban: allow cancelling a quick create
-rw-r--r--addons/web/static/src/js/views/kanban/kanban_column.js2
-rw-r--r--addons/web/static/test/views/kanban_tests.js12
2 files changed, 11 insertions, 3 deletions
diff --git a/addons/web/static/src/js/views/kanban/kanban_column.js b/addons/web/static/src/js/views/kanban/kanban_column.js
index 31e2e94ca1b..66fb538872c 100644
--- a/addons/web/static/src/js/views/kanban/kanban_column.js
+++ b/addons/web/static/src/js/views/kanban/kanban_column.js
@@ -251,7 +251,7 @@ var KanbanColumn = Widget.extend({
* @private
*/
_onCancelQuickCreate: function () {
- this.cancelQuickCreate();
+ this._cancelQuickCreate();
},
/**
* @private
diff --git a/addons/web/static/test/views/kanban_tests.js b/addons/web/static/test/views/kanban_tests.js
index 2d837d8e541..2b882cd7aa6 100644
--- a/addons/web/static/test/views/kanban_tests.js
+++ b/addons/web/static/test/views/kanban_tests.js
@@ -319,7 +319,7 @@ QUnit.module('Views', {
});
QUnit.test('quick create in grouped mode', function (assert) {
- assert.expect(3);
+ assert.expect(4);
var kanban = createView({
View: KanbanView,
@@ -333,19 +333,27 @@ QUnit.module('Views', {
groupBy: ['bar'],
});
+ // click to add an element and cancel the quick creation
kanban.$('.o_kanban_header .o_kanban_quick_add i').first().click();
var $quickCreate = kanban.$('.o_kanban_quick_create');
assert.strictEqual($quickCreate.length, 1, "should have a quick create element");
+ $quickCreate.find('input').trigger($.Event('keydown', {keyCode: $.ui.keyCode.ESCAPE}));
+ assert.strictEqual(kanban.$('.o_kanban_quick_create').length, 0,
+ "should have destroyed the quick create element");
+
+ // click to really add an element
+ kanban.$('.o_kanban_header .o_kanban_quick_add i').first().click();
+ $quickCreate = kanban.$('.o_kanban_quick_create');
$quickCreate.find('input').val('new partner');
$quickCreate.find('button.o_kanban_add').click();
assert.strictEqual(this.data.partner.records.length, 5,
"should have created a partner");
-
assert.strictEqual(_.last(this.data.partner.records).name, "new partner",
"should have correct name");
+
kanban.destroy();
});