[FIX] mrp: Existing operations can only be added to one BOM

Generic operations will be applied for every manufactured product passing
through the work center.

An operation linked to a bom will only be applied when the specific manufactured bom is produced

So on a BOM, every operations must be created for this specific BOM

The widget many2many is wrong because it will overwrite the generic operations

opw:2458974

closes odoo/odoo#66874

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

2 files changed, 20 insertions, 36 deletions

diff --git a/addons/mrp/tests/test_bom.py b/addons/mrp/tests/test_bom.py
index a4788968082..bfa47231ca3 100644
--- a/addons/mrp/tests/test_bom.py
+++ b/addons/mrp/tests/test_bom.py
@@ -331,24 +331,6 @@ class TestBoM(TestMrpCommon):
             'name': 'Deserts Table'
         })
 
-        operation_1 = self.env['mrp.routing.workcenter'].create({
-            'workcenter_id': workcenter.id,
-            'name': 'Prepare biscuits',
-            'time_cycle_manual': 5
-        })
-
-        operation_2 = self.env['mrp.routing.workcenter'].create({
-            'workcenter_id': workcenter.id,
-            'name': 'Prepare butter',
-            'time_cycle_manual': 3
-        })
-
-        operation_3 = self.env['mrp.routing.workcenter'].create({
-            'workcenter_id': workcenter.id,
-            'name': 'Mix manually',
-            'time_cycle_manual': 5
-        })
-
         with Form(bom_crumble) as bom:
             with bom.bom_line_ids.new() as line:
                 line.product_id = butter
@@ -358,9 +340,18 @@ class TestBoM(TestMrpCommon):
                 line.product_id = biscuit
                 line.product_uom_id = uom_kg
                 line.product_qty = 6
-            bom.operation_ids.add(operation_1)
-            bom.operation_ids.add(operation_2)
-            bom.operation_ids.add(operation_3)
+            with bom.operation_ids.new() as operation:
+                operation.workcenter_id = workcenter
+                operation.name = 'Prepare biscuits'
+                operation.time_cycle_manual = 5
+            with bom.operation_ids.new() as operation:
+                operation.workcenter_id = workcenter
+                operation.name = 'Prepare butter'
+                operation.time_cycle_manual = 3
+            with bom.operation_ids.new() as operation:
+                operation.workcenter_id = workcenter
+                operation.name = 'Mix manually'
+                operation.time_cycle_manual = 5
 
         # TEST BOM STRUCTURE VALUE WITH BOM QUANTITY
         report_values = self.env['report.mrp.report_bom_structure']._get_report_data(bom_id=bom_crumble.id, searchQty=11, searchVariant=False)
@@ -437,18 +428,6 @@ class TestBoM(TestMrpCommon):
             'time_stop': 15
         })
 
-        operation_4 = self.env['mrp.routing.workcenter'].create({
-            'workcenter_id': workcenter.id,
-            'name': 'Mix cheese and crumble',
-            'time_cycle_manual': 10
-        })
-
-        operation_5 = self.env['mrp.routing.workcenter'].create({
-            'workcenter_id': workcenter_2.id,
-            'name': 'Cake mounting',
-            'time_cycle_manual': 5
-        })
-
         with Form(bom_cheese_cake) as bom:
             with bom.bom_line_ids.new() as line:
                 line.product_id = cream
@@ -458,8 +437,14 @@ class TestBoM(TestMrpCommon):
                 line.product_id = crumble
                 line.product_uom_id = uom_kg
                 line.product_qty = 5.4
-            bom.operation_ids.add(operation_4)
-            bom.operation_ids.add(operation_5)
+            with bom.operation_ids.new() as operation:
+                operation.workcenter_id = workcenter
+                operation.name = 'Mix cheese and crumble'
+                operation.time_cycle_manual = 10
+            with bom.operation_ids.new() as operation:
+                operation.workcenter_id = workcenter_2
+                operation.name = 'Cake mounting'
+                operation.time_cycle_manual = 5
 
 
         # TEST CHEESE BOM STRUCTURE VALUE WITH BOM QUANTITY
diff --git a/addons/mrp/views/mrp_bom_views.xml b/addons/mrp/views/mrp_bom_views.xml
index f582ddb4acb..94afb0e8850 100644
--- a/addons/mrp/views/mrp_bom_views.xml
+++ b/addons/mrp/views/mrp_bom_views.xml
@@ -101,7 +101,6 @@
                             attrs="{'invisible': [('type', 'not in',('normal','phantom'))]}"
                             groups="mrp.group_mrp_routings">
                                 <field name="operation_ids"
-                                    widget="many2many"
                                     attrs="{'invisible': [('type','not in',('normal','phantom'))]}"
                                     groups="mrp.group_mrp_routings"
                                     context="{'default_company_id': company_id, 'default_product_tmpl_ids': [product_tmpl_id]}"/>