diff options
| author | Xavier Morel <xmo@openerp.com> | 2011-10-03 11:07:09 +0200 |
|---|---|---|
| committer | Xavier Morel <xmo@openerp.com> | 2011-10-03 11:07:09 +0200 |
| commit | a9da2abd9f2ebcf1ecb548c683c8aeeaa7ffb72e (patch) | |
| tree | be75edf6923e9acd99a9078ad3448b6703b87221 | |
| parent | bb596c1bfcd4bb386575f4a36bea264f00597861 (diff) | |
[FIX] double-load on successful login
Session#session_restore is automatically called when the client
session is started, and it performs an RPC call. This RPC call is
checked and leads to the opening of the login form iif the user is not
currently logged in (does not have a valid session).
Due to the behavior of Session#rpc_ajax, this failure on grounds of
invalid session leads to the restore continuation being stored for
deferred execution once the user logs in.
Issue is that both Session#session_login and Session#session_restore
call Session#on_session_valid which tries to load all modules. As a
result and because the '_modules_loaded' flag is only set five billion
years after 'load_modules' is called both calls will try to load all
modules in parallel, leading to double downloading and execution of
all JS and CSS files coming from module data (including translation
files).
bzr revid: xmo@openerp.com-20111003090709-ree0luomezw1wzup
| -rw-r--r-- | addons/web/static/src/js/core.js | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/addons/web/static/src/js/core.js b/addons/web/static/src/js/core.js index 2e9294ded12..5bc6bc92b68 100644 --- a/addons/web/static/src/js/core.js +++ b/addons/web/static/src/js/core.js @@ -486,8 +486,6 @@ openerp.web.Session = openerp.web.CallbackEnabled.extend( /** @lends openerp.web self.user_context = result.context; self.db = result.db; self.session_save(); - if (self.uid) - self.on_session_valid(); return true; }).then(success_callback); }, |