diff options
| author | Priyanka Kakadiya <pka@odoo.com> | 2020-09-17 05:45:34 +0000 |
|---|---|---|
| committer | Priyanka Kakadiya <pka@odoo.com> | 2020-09-18 10:28:19 +0000 |
| commit | 9fed44512074d36f7b4aedf8ed08422304e433ea (patch) | |
| tree | 030efb48e4fac84150eaf92f2a1e54f9d9fa2201 | |
| parent | ad2cc2fe43cb80a7ab3b0bcd08ea29aa5b403761 (diff) | |
[FIX] sms: fix sending failures sms wizard
due to breaking changes in https://github.com/odoo/odoo/commit/bf32b22ce247c19fda94ded74e37f7c6120ce2c4
and especially the part:
"NOTE 1. If the default_get within the onchange returns a value for
a field that is not in the view, we ignore it, and it won't be saved.
Before, that value was kept and sent upon save. This change in behavior
may prove problematic, although the overall risk is small. Decision has
been made to keep heavy comments and code snippets if we were to revert
back somehow to the previous situation."
the wizard to sending failures sms was broken as the field notification_id
which is required was not present in the view and was thus ignored by
to web client when calling 'create'.
closes odoo/odoo#57912
Task: 2335273
Closes: https://github.com/odoo/odoo/pull/57912
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
| -rw-r--r-- | addons/sms/wizard/sms_resend_views.xml | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/addons/sms/wizard/sms_resend_views.xml b/addons/sms/wizard/sms_resend_views.xml index fb925f8aa0a..2f13881f63e 100644 --- a/addons/sms/wizard/sms_resend_views.xml +++ b/addons/sms/wizard/sms_resend_views.xml @@ -16,6 +16,7 @@ <field name="sms_number"/> <field name="failure_type" string="Reason"/> <field name="resend" widget="boolean_toggle"/> + <field name="notification_id" invisible="1"/> </tree> </field> <div class="alert alert-warning" role="alert" attrs="{'invisible': [('has_cancel', '=', False)]}"> |