summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVictor Feyens <vfe@odoo.com>2020-06-30 15:37:18 +0000
committerThibault Delavallée <tde@odoo.com>2020-09-02 13:33:57 +0000
commit90f8e9255fa46c408763346ed135d9e561ae7fd5 (patch)
tree87cbef66ae6368906a774c1fdbea47cfbadd13a2
parent977c2b9d12419fba3bada1ebefcca15f051ca565 (diff)
[FIX] various: remove duplicate fields definition in kanban views preface
Remove duplicate fields in tree views / kanban (outside of templates). A field should not be present twice in a kanban view. If one of the nodes has custom attributes behavior of other nodes is somehow unpredicatable. Having field present only once gives a more coherent behavior. Xpaths could also lead to weird results if fields are present several times. Notably adding a field in the view preface instead of inside the view template itself (see b63043e for example of fix). An heuristic to detect duplicate fields will land soon in master. As this commit targets a stable version only view fixes are provided. Task ID-2329114 PR odoo/odoo#56946
-rw-r--r--addons/account/views/account_move_views.xml1
-rw-r--r--addons/mail/views/mail_message_views.xml1
-rw-r--r--addons/maintenance/views/maintenance_views.xml1
3 files changed, 0 insertions, 3 deletions
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 92d8578c576..664e151df21 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -778,7 +778,6 @@
<field name="product_uom_category_id" invisible="1"/>
<field name="product_uom_id" groups="uom.group_uom"/>
<field name="price_unit"/>
- <field name="display_type"/>
<templates>
<t t-name="kanban-box">
<div t-attf-class="oe_kanban_card oe_kanban_global_click {{ record.display_type.raw_value ? 'o_is_' + record.display_type.raw_value : '' }}">
diff --git a/addons/mail/views/mail_message_views.xml b/addons/mail/views/mail_message_views.xml
index 193bcf7e099..f0405ea3fec 100644
--- a/addons/mail/views/mail_message_views.xml
+++ b/addons/mail/views/mail_message_views.xml
@@ -142,7 +142,6 @@
<field name="type"/>
<field name="create_uid"/>
<field name="url"/>
- <field name="type"/>
<field name="create_date"/>
<field name="name"/>
<templates>
diff --git a/addons/maintenance/views/maintenance_views.xml b/addons/maintenance/views/maintenance_views.xml
index 4a2d20f3cd8..1c63dd09f32 100644
--- a/addons/maintenance/views/maintenance_views.xml
+++ b/addons/maintenance/views/maintenance_views.xml
@@ -422,7 +422,6 @@
<field name="maintenance_ids"/>
<field name="maintenance_open_count"/>
<field name="next_action_date"/>
- <field name="technician_user_id"/>
<field name="activity_ids" />
<field name="activity_state" />
<progressbar field="activity_state" colors='{"planned": "success", "today": "warning", "overdue": "danger"}'/>