summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristophe Simonis <chs@odoo.com>2017-12-01 10:49:32 +0100
committerChristophe Simonis <chs@odoo.com>2017-12-01 10:49:32 +0100
commit676c982edaa448824292d712245fbf27aceb4f18 (patch)
treead210bff8f4a07cfb9df5b56b6dc662511761915
parent42264d8dcb7f8d0795c84718d1fc9a5fd1aefd32 (diff)
[FIX] stock{,_picking_batch}: correct public method return value
-rw-r--r--addons/stock/wizard/stock_immediate_transfer.py2
-rw-r--r--addons/stock_picking_batch/wizard/stock_immediate_transfer.py3
2 files changed, 3 insertions, 2 deletions
diff --git a/addons/stock/wizard/stock_immediate_transfer.py b/addons/stock/wizard/stock_immediate_transfer.py
index 708494aba2a..e137f5ad85d 100644
--- a/addons/stock/wizard/stock_immediate_transfer.py
+++ b/addons/stock/wizard/stock_immediate_transfer.py
@@ -37,4 +37,4 @@ class StockImmediateTransfer(models.TransientModel):
pick_to_do.action_done()
if pick_to_backorder:
return pick_to_backorder.action_generate_backorder_wizard()
- return True
+ return False
diff --git a/addons/stock_picking_batch/wizard/stock_immediate_transfer.py b/addons/stock_picking_batch/wizard/stock_immediate_transfer.py
index 57de52d59af..9361d18dbe3 100644
--- a/addons/stock_picking_batch/wizard/stock_immediate_transfer.py
+++ b/addons/stock_picking_batch/wizard/stock_immediate_transfer.py
@@ -11,10 +11,11 @@ class StockImmediateTransfer(models.TransientModel):
def process(self):
backorder_wizard_dict = super(StockImmediateTransfer, self).process()
# If the immediate transfer wizard process all our picking but with some back order maybe needed we want to add the backorder already passed to the wizard.
- if backorder_wizard_dict is not None:
+ if backorder_wizard_dict:
backorder_wizard = self.env['stock.backorder.confirmation'].browse(backorder_wizard_dict.get('res_id', False))
backorder_wizard.write({'pick_ids': [(4, p.id) for p in self.pick_to_backorder_ids]})
return backorder_wizard_dict
# If there is no backorder returned by the immediate transfer basic function we still wanted to process those manually given
elif self.pick_to_backorder_ids:
return self.pick_to_backorder_ids.action_generate_backorder_wizard()
+ return False