diff options
| author | Christophe Monniez <moc@odoo.com> | 2018-02-14 08:06:12 +0100 |
|---|---|---|
| committer | Vincent Schippefilt <vsc@odoo.com> | 2018-04-10 09:32:30 +0200 |
| commit | 4ba6d2a405c7362986e8a09702e6228887632ea1 (patch) | |
| tree | cab325e50af629ced5619c8d50fc0d035ec44ba1 | |
| parent | 3ae9dde258303b8212ae47654edf00e5879e8bab (diff) | |
[IMP] tests: make phantomjs work on Windows
Since Python 3.2, close_fds parameter is True by default on POSIX
platforms. On Windows, it's set to False when one of the standard descriptors
is set.
This commit will give the opportunity to run phantom js tests on
Windows.
| -rw-r--r-- | odoo/tests/common.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/odoo/tests/common.py b/odoo/tests/common.py index 165e4459779..3c4344b3a1e 100644 --- a/odoo/tests/common.py +++ b/odoo/tests/common.py @@ -449,7 +449,7 @@ class HttpCase(TransactionCase): _logger.info('phantomjs unlink localstorage %s', i) os.unlink(i) try: - phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None, close_fds=True) + phantom = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=None) except OSError: raise unittest.SkipTest("PhantomJS not found") try: |