diff options
| author | yhu-odoo <yhu@odoo.com> | 2020-08-04 14:59:21 +0000 |
|---|---|---|
| committer | yhu-odoo <yhu@odoo.com> | 2020-08-11 12:19:24 +0000 |
| commit | 48c2c1eb9f8f9b112e169a46101cee6cc7424a0a (patch) | |
| tree | 087c2bf76444570f1789f2c3b82cbc10d856f76f | |
| parent | 2cd1aec3d09495554c7ea931d278392c180958b8 (diff) | |
[FIX] web_tour: clear _transitionEndTimer before destory the tip widget
Before this commit, when we doing the tour. If we move the mouse fast
enough. We may trigger the tip_consumed event before its
_transitionEndTimer call its callback to update the position, and a
bubble will be left there.
In this commit, we clear the _transitionEndTimer timeout before we
destory the widget to prevent the issue.
Task 2298950
PR #55155
| -rw-r--r-- | addons/web_tour/static/src/js/tip.js | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/addons/web_tour/static/src/js/tip.js b/addons/web_tour/static/src/js/tip.js index cf32027324a..b69baf03ff8 100644 --- a/addons/web_tour/static/src/js/tip.js +++ b/addons/web_tour/static/src/js/tip.js @@ -107,6 +107,9 @@ var Tip = Widget.extend({ this._unbind_anchor_events(); clearTimeout(this.timerIn); clearTimeout(this.timerOut); + // clear this timeout so that we won't call _updatePosition after we + // destroy the widget and leave an undesired bubble. + clearTimeout(this._transitionEndTimer); // Do not remove the parent class if it contains other tooltips const _removeParentClass = $el => { |