diff options
| author | Thibault Delavallée <tde@odoo.com> | 2021-03-29 08:02:44 +0000 |
|---|---|---|
| committer | Thibault Delavallée <tde@odoo.com> | 2021-03-29 12:57:32 +0000 |
| commit | 43bf5a5f048115a94eecc7a23a7e3fea119ac76c (patch) | |
| tree | d9aca63d1cdc132bfb205425519d5c8ae27a12a0 | |
| parent | 157eee07ba74de1dad30510a85411eeff2b2dcf1 (diff) | |
[FIX] calendar_sms, hr_presence: fix broken acls update on sms.template
odoo/odoo#64626 attempt at improving sms.template rules seems quite broken
* do not restrict system group to calendar.event: this makes no sense.
With this fix admins can now only use templates being linked to calendar
event if calendar_sms is installed which is not really smart. Not sure
what was the exact original purpose;
* ir.rule in hr_presence has no use on hr.manager group if they do not
have any access through access rules. Indeed they are currently
restricted to read access as all standard internal users;
Task ID-2191254
COM PR odoo/odoo#68445
ENT PR odoo/enterprise#17340
closes odoo/odoo#68465
X-original-commit: 7c4c20a6be78c98e44fcc580b54a12110d238a65
Related: odoo/enterprise#17348
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
| -rw-r--r-- | addons/calendar_sms/security/sms_security.xml | 5 | ||||
| -rw-r--r-- | addons/hr_presence/__manifest__.py | 1 | ||||
| -rw-r--r-- | addons/hr_presence/security/ir.model.access.csv | 2 |
3 files changed, 6 insertions, 2 deletions
diff --git a/addons/calendar_sms/security/sms_security.xml b/addons/calendar_sms/security/sms_security.xml index 4b6d11ccde9..30714c2ccbb 100644 --- a/addons/calendar_sms/security/sms_security.xml +++ b/addons/calendar_sms/security/sms_security.xml @@ -1,10 +1,11 @@ <?xml version="1.0" encoding="utf-8"?> <odoo> <record id="ir_rule_sms_template_system" model="ir.rule"> - <field name="name">SMS Template: system administrator CUD on calendar event templates</field> + <field name="name">SMS Template: unnecessary rule for system group</field> <field name="model_id" ref="sms.model_sms_template"/> <field name="groups" eval="[(4, ref('base.group_system'))]"/> - <field name="domain_force">[('model_id.model', '=', 'calendar.event')]</field> + <!-- TDE NOTE: remove me in master, broken fix from odoo/odoo#64626 --> + <field name="domain_force">[(1, '=', 1)]</field> <field name="perm_read" eval="False"/> </record> </odoo> diff --git a/addons/hr_presence/__manifest__.py b/addons/hr_presence/__manifest__.py index eac227f7353..e854ce7eda7 100644 --- a/addons/hr_presence/__manifest__.py +++ b/addons/hr_presence/__manifest__.py @@ -19,6 +19,7 @@ Allows to contact directly the employee in case of unjustified absence. 'depends': ['hr', 'hr_holidays', 'sms'], 'data': [ 'security/sms_security.xml', + 'security/ir.model.access.csv', 'data/ir_actions_server.xml', 'views/hr_employee_views.xml', 'data/sms_data.xml', diff --git a/addons/hr_presence/security/ir.model.access.csv b/addons/hr_presence/security/ir.model.access.csv new file mode 100644 index 00000000000..cbbbcff9990 --- /dev/null +++ b/addons/hr_presence/security/ir.model.access.csv @@ -0,0 +1,2 @@ +id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink +access_sms_template_hr_manager,access.sms.template.hr.manager,sms.model_sms_template,hr.group_hr_manager,1,1,1,1 |