diff options
| author | Lucas Perais (lpe) <lpe@odoo.com> | 2018-11-07 16:39:15 +0000 |
|---|---|---|
| committer | Lucas Perais (lpe) <lpe@odoo.com> | 2018-11-13 10:09:03 +0000 |
| commit | 40b4584b009a979dcfbff4f464a6bdbbbebc583e (patch) | |
| tree | 18207d32dd669c041e21d43b210cbe8f5e951c18 | |
| parent | 09fde268545a54b4ac9e0e121619a24580b69792 (diff) | |
[FIX] *: boolean in domains should have value True or False
Because the JS cannot handle 1 or 0 being equivalent to true or false, the views should comply
Issues specifically arise in the kanban view when, instead of reloading every record with python,
the JS actually computes which record should be displayed by reinterpreting the domain
From a user point of view, on a fresh db with CRM installed, go to the app kanban view
Click on the contextual menu of the CRM kanban label, click uninstall
The modal opens, but click cancel. The kanban label of the kanban view has disappeared
This is due to commit 33ba61bfdbdc1d9d986070c677f6bf18cbacf6b2, which prevents reloading all the view
for performance purposes
This commit prevents the label from disappearing
OPW 1903534
closes odoo/odoo#28484
| -rw-r--r-- | addons/membership/views/partner_views.xml | 4 | ||||
| -rw-r--r-- | addons/membership/views/product_views.xml | 2 | ||||
| -rw-r--r-- | addons/product/views/product_views.xml | 4 | ||||
| -rw-r--r-- | odoo/addons/base/views/ir_module_views.xml | 4 | ||||
| -rw-r--r-- | odoo/addons/base/views/res_partner_views.xml | 10 |
5 files changed, 12 insertions, 12 deletions
diff --git a/addons/membership/views/partner_views.xml b/addons/membership/views/partner_views.xml index d7235e3998a..739f0cff968 100644 --- a/addons/membership/views/partner_views.xml +++ b/addons/membership/views/partner_views.xml @@ -28,9 +28,9 @@ <field name="category_id"/> <field name="membership_start" invisible="1"/> <field name="membership_stop" string="End Membership Date"/> - <filter string="Customers" name="customer" domain="[('customer','=',1)]"/> + <filter string="Customers" name="customer" domain="[('customer','=',True)]"/> <separator/> - <filter string="Vendors" name="supplier" domain="[('supplier','=',1)]"/> + <filter string="Vendors" name="supplier" domain="[('supplier','=',True)]"/> <separator/> <filter name="all_non_members" domain="[('membership_state', 'in', ['none','canceled','old','waiting'])]" string="All non Members" help="None/Canceled/Old/Waiting"/> <filter name="all_members" domain="[('membership_state', 'in', ['invoiced','paid','free'])]" string="All Members" help="Invoiced/Paid/Free"/> diff --git a/addons/membership/views/product_views.xml b/addons/membership/views/product_views.xml index 80192e9bad8..1acbfaa183c 100644 --- a/addons/membership/views/product_views.xml +++ b/addons/membership/views/product_views.xml @@ -12,7 +12,7 @@ <field name="arch" type="xml"> <search string="Membership Products"> <field name="name" string="Membership Product"/> - <filter string="Inactive" name="inactive" domain="[('active','=',0)]"/> + <filter string="Inactive" name="inactive" domain="[('active','=',False)]"/> <field name="categ_id" operator="child_of"/> <group expand='0' string='Group by...'> <filter string='Category' name="category" domain="[]" context="{'group_by' : 'categ_id'}"/> diff --git a/addons/product/views/product_views.xml b/addons/product/views/product_views.xml index 437693ecce3..b30c3d89c57 100644 --- a/addons/product/views/product_views.xml +++ b/addons/product/views/product_views.xml @@ -138,8 +138,8 @@ <filter string="Services" name="services" domain="[('type','=','service')]"/> <filter string="Products" name="consumable" domain="[('type', 'in', ['consu', 'product'])]"/> <separator/> - <filter string="Can be Sold" name="filter_to_sell" domain="[('sale_ok','=',1)]"/> - <filter string="Can be Purchased" name="filter_to_purchase" domain="[('purchase_ok', '=', 1)]"/> + <filter string="Can be Sold" name="filter_to_sell" domain="[('sale_ok','=',True)]"/> + <filter string="Can be Purchased" name="filter_to_purchase" domain="[('purchase_ok', '=', True)]"/> <separator/> <filter string="Archived" name="inactive" domain="[('active','=',False)]"/> <field string="Attributes" name="attribute_line_ids" groups="product.group_product_variant"/> diff --git a/odoo/addons/base/views/ir_module_views.xml b/odoo/addons/base/views/ir_module_views.xml index ebf6700ecea..7f1bb9727a9 100644 --- a/odoo/addons/base/views/ir_module_views.xml +++ b/odoo/addons/base/views/ir_module_views.xml @@ -37,8 +37,8 @@ <search string="Search modules"> <field name="name" filter_domain="['|', '|', ('summary', 'ilike', self), ('shortdesc', 'ilike', self), ('name', 'ilike', self)]" string="Module"/> - <filter name="app" string="Apps" domain="[('application', '=', 1)]"/> - <filter name="extra" string="Extra" domain="[('application', '=', 0)]"/> + <filter name="app" string="Apps" domain="[('application', '=', True)]"/> + <filter name="extra" string="Extra" domain="[('application', '=', False)]"/> <separator/> <filter name="installed" string="Installed" domain="[('state', 'in', ['installed', 'to upgrade', 'to remove'])]"/> <filter name="not_installed" string="Not Installed" domain="[('state', 'in', ['uninstalled', 'uninstallable', 'to install'])]"/> diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml index 9a86939782b..1880589a326 100644 --- a/odoo/addons/base/views/res_partner_views.xml +++ b/odoo/addons/base/views/res_partner_views.xml @@ -449,15 +449,15 @@ <search string="Search Partner"> <field name="name" filter_domain="['|','|',('display_name','ilike',self),('ref','=',self),('email','ilike',self)]"/> - <field name="parent_id" domain="[('is_company','=',1)]" operator="child_of"/> + <field name="parent_id" domain="[('is_company','=',True)]" operator="child_of"/> <filter name="filter_my_partners" help="My Contacts" domain="[('user_id','=',uid)]"/> <separator/> - <filter string="Individuals" name="type_person" domain="[('is_company','=',0)]"/> - <filter string="Companies" name="type_company" domain="[('is_company','=',1)]"/> + <filter string="Individuals" name="type_person" domain="[('is_company','=',False)]"/> + <filter string="Companies" name="type_company" domain="[('is_company','=',True)]"/> <separator/> - <filter string="Customers" name="customer" domain="[('customer','=',1), ('parent_id', '=', False)]"/> - <filter string="Vendors" name="supplier" domain="[('supplier','=',1), ('parent_id', '=', False)]"/> + <filter string="Customers" name="customer" domain="[('customer','=',True), ('parent_id', '=', False)]"/> + <filter string="Vendors" name="supplier" domain="[('supplier','=',True), ('parent_id', '=', False)]"/> <filter string="Archived" name="inactive" domain="[('active','=',False)]"/> <separator/> <field name="category_id" string="Tag" filter_domain="[('category_id','ilike', self)]"/> |
