diff options
| author | Martin Geubelle <mge@odoo.com> | 2017-04-14 13:01:28 +0200 |
|---|---|---|
| committer | Martin Geubelle <mge@odoo.com> | 2017-04-19 17:49:34 +0200 |
| commit | 3b3e71c2dd6d3f5edd679f04ef5572cbbdb5947b (patch) | |
| tree | f314dace09e516f77fa0cc13036c92d4f99a37d0 | |
| parent | 90d6573579768525e339fa843a906016befd8aab (diff) | |
[FIX] web_kanban: remove add new column on 'Discard'
The 'Add New Column' was still in `folded` mode after clicking on 'Discard'
because the mode was toggle two times: one by `_cancel` and another one by
`_onClick` which already toggles the mode.
| -rw-r--r-- | addons/web/static/src/js/views/kanban/kanban_quick_create.js | 8 | ||||
| -rw-r--r-- | addons/web/static/tests/views/kanban_tests.js | 11 |
2 files changed, 10 insertions, 9 deletions
diff --git a/addons/web/static/src/js/views/kanban/kanban_quick_create.js b/addons/web/static/src/js/views/kanban/kanban_quick_create.js index 9cbd4af56d4..a87ac76d53f 100644 --- a/addons/web/static/src/js/views/kanban/kanban_quick_create.js +++ b/addons/web/static/src/js/views/kanban/kanban_quick_create.js @@ -185,14 +185,6 @@ var ColumnQuickCreate = AbstractQuickCreate.extend({ //-------------------------------------------------------------------------- /** - * @override - * @private - */ - _cancel: function () { - this.folded = true; - this._update(); - }, - /** * Triggers up an event to quick create a column with the given value * * @override diff --git a/addons/web/static/tests/views/kanban_tests.js b/addons/web/static/tests/views/kanban_tests.js index c4d224b4f79..ae0eda0bba0 100644 --- a/addons/web/static/tests/views/kanban_tests.js +++ b/addons/web/static/tests/views/kanban_tests.js @@ -587,7 +587,7 @@ QUnit.module('Views', { }); QUnit.test('create a column in grouped on m2o', function (assert) { - assert.expect(10); + assert.expect(12); var nbRPCs = 0; var kanban = createView({ @@ -618,6 +618,15 @@ QUnit.module('Views', { assert.ok(kanban.$('.o_column_quick_create input').is(':visible'), "the input should be visible"); + // discard the column creation and click it again + kanban.$('.o_column_quick_create .o_kanban_cancel').click(); + assert.notOk(kanban.$('.o_column_quick_create input').is(':visible'), + "the input should not be visible after discard"); + + kanban.$('.o_column_quick_create').click(); + assert.ok(kanban.$('.o_column_quick_create input').is(':visible'), + "the input should be visible"); + kanban.$('.o_column_quick_create input').val('new value'); kanban.$('.o_column_quick_create button.o_kanban_add').click(); |
