diff options
| author | Thibault Delavallée <tde@odoo.com> | 2021-03-30 07:49:26 +0000 |
|---|---|---|
| committer | Thibault Delavallée <tde@odoo.com> | 2021-03-30 09:49:29 +0000 |
| commit | 362f9d003fbe0f629926224ae9bd18c9028d9a1d (patch) | |
| tree | 1dbb00d48db022cfa7a64c5ea36ddc9c8cfb6f00 | |
| parent | f9cdaa3deef305ce45aba7e9102ac23ef6f5fac1 (diff) | |
[FIX] sms: ensure group system has full rights on sms.template model
As no global rule is defined for system, people belonging to both system
and a functional group may be limited in their rights about sms templates.
For example install event_sms -> admin is member of system and event manager
groups. He cannot edit templates other than related to event.
With this commit members of system may write, create or unlink all templates
independently from their functinal groups.
Task ID-2495426
Followup of odoo/odoo#64626
closes odoo/odoo#68530
X-original-commit: e0c1563993da918a0fbc2e31a13f3fe6a7ea2916
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
| -rw-r--r-- | addons/sms/__manifest__.py | 1 | ||||
| -rw-r--r-- | addons/sms/security/sms_security.xml | 9 | ||||
| -rw-r--r-- | addons/sms/tests/test_sms_template.py | 2 |
3 files changed, 11 insertions, 1 deletions
diff --git a/addons/sms/__manifest__.py b/addons/sms/__manifest__.py index 086087b5c2d..5d16f4fc1f0 100644 --- a/addons/sms/__manifest__.py +++ b/addons/sms/__manifest__.py @@ -32,6 +32,7 @@ The service is provided by the In App Purchase Odoo platform. 'views/sms_sms_views.xml', 'views/sms_template_views.xml', 'security/ir.model.access.csv', + 'security/sms_security.xml', ], 'demo': [ 'data/sms_demo.xml', diff --git a/addons/sms/security/sms_security.xml b/addons/sms/security/sms_security.xml new file mode 100644 index 00000000000..8345189aa6c --- /dev/null +++ b/addons/sms/security/sms_security.xml @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="utf-8"?> +<odoo> + <record id="ir_rule_sms_template_system" model="ir.rule"> + <field name="name">SMS Template: system group granted all</field> + <field name="model_id" ref="sms.model_sms_template"/> + <field name="groups" eval="[(4, ref('base.group_system'))]"/> + <field name="domain_force">[(1, '=', 1)]</field> + </record> +</odoo> diff --git a/addons/sms/tests/test_sms_template.py b/addons/sms/tests/test_sms_template.py index 0284108cc2f..8e3bbfae3a6 100644 --- a/addons/sms/tests/test_sms_template.py +++ b/addons/sms/tests/test_sms_template.py @@ -15,7 +15,7 @@ class TestSmsTemplateAccessRights(SavepointCase): super().setUpClass() cls.user_admin = mail_new_test_user(cls.env, login='user_system', groups='base.group_system') cls.basic_user = mail_new_test_user(cls.env, login='user_employee', groups='base.group_user') - sms_enabled_models = cls.env['ir.model'].search([('is_mail_thread_sms', '=', True), ('transient', '=', False)]) + sms_enabled_models = cls.env['ir.model'].search([('is_mail_thread', '=', True), ('transient', '=', False)]) vals = [] for model in sms_enabled_models: vals.append({ |