diff options
| author | Toufik Ben Jaa <tbe@odoo.com> | 2019-05-22 12:31:41 +0000 |
|---|---|---|
| committer | Toufik Ben Jaa <tbe@odoo.com> | 2019-05-22 12:31:41 +0000 |
| commit | 1569bef308d6e7769288ebe20d8a30a952439e2e (patch) | |
| tree | b9290259b921e2e999dc5874f7d6d2c32f6bf06b | |
| parent | e9430ac5c1ed41b19b208e02ac8f3d9782f1ad0e (diff) | |
[FIX] hr: `phone` field on `res.users` is shadowed
- The added field `phone` on `res.users` shadow the field `phone`
inherited by `res.partner`.
The issue is that the field `phone` on `hr.employee` can be read only
by the employee or the HR team.
A lot of views tries to display the field `phone` expecting the one
declared in `res.partner` which should be readable by everyone.
But the one declared in `res.users` shadows it.
closes odoo/odoo#33569
Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
| -rw-r--r-- | addons/hr/models/res_users.py | 4 | ||||
| -rw-r--r-- | addons/hr/views/res_users.xml | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/addons/hr/models/res_users.py b/addons/hr/models/res_users.py index 8398b543776..a74088498b7 100644 --- a/addons/hr/models/res_users.py +++ b/addons/hr/models/res_users.py @@ -15,7 +15,7 @@ class User(models.Model): job_title = fields.Char(related='employee_id.job_title', readonly=False) work_phone = fields.Char(related='employee_id.work_phone', readonly=False) mobile_phone = fields.Char(related='employee_id.mobile_phone', readonly=False) - phone = fields.Char(related='employee_id.phone', readonly=False, related_sudo=False) + employee_phone = fields.Char(related='employee_id.phone', readonly=False, related_sudo=False) work_email = fields.Char(related='employee_id.work_email', readonly=False, related_sudo=False) category_ids = fields.Many2many(related='employee_id.category_ids', string="Employee Tags", readonly=False, related_sudo=False) department_id = fields.Many2one(related='employee_id.department_id', readonly=False, related_sudo=False) @@ -90,7 +90,7 @@ class User(models.Model): 'parent_id', 'passport_id', 'permit_no', - 'phone', + 'employee_phone', 'pin', 'place_of_birth', 'spouse_birthdate', diff --git a/addons/hr/views/res_users.xml b/addons/hr/views/res_users.xml index b2e64082bd3..de407838721 100644 --- a/addons/hr/views/res_users.xml +++ b/addons/hr/views/res_users.xml @@ -87,7 +87,7 @@ It should be different from the work address. </div> <field name="km_home_work"/> - <field name="phone"/> + <field name="employee_phone"/> <field name="employee_bank_account_id"/> </group> <group string="Citizenship"> |
