diff options
| author | Adrien Widart <awt@odoo.com> | 2020-12-22 07:10:46 +0000 |
|---|---|---|
| committer | Adrien Widart <awt@odoo.com> | 2020-12-24 10:55:27 +0000 |
| commit | 13e33fdd9722a7022d56538ab69dda0200b3aaa2 (patch) | |
| tree | 35b80ff937a297042b05d66f8528a6867a9f007c | |
| parent | 13fcbf9a52794d5f4b53cd5d0b7ae4effe6888ce (diff) | |
[FIX] account: list all credit note methods
When adding a credit note, the user can only select the "Partial
Refund" credit method.
To reproduce the error:
1. Go to Invoicing
2. Create a new one
- Add at least one invoice line
3. Save, Confirm
4. Click on "Add Credit Note"
=> You can not change the credit method.
The method field is editable only when the residual amount is different
from 0. Here is the issue: when clicking on "Add Credit Note", it
actually triggers some `onchange` methods. The latter uses a new record
to compute the values:
https://github.com/odoo/odoo/blob/45422d56bce413b8577f1784e10dd22ede93c751/odoo/models.py#L6147-L6148
Then, some `_compute` methods are also triggered. Among them, the amount
residual computation of the associated `account_move_line`. However,
`_compute_amount_residual` will skip the not-yet-created objects and set
the amount residual to 0. This is the reason why the residual amount of
the account move is zero and therefore, the user can't change the credit
method.
OPW-2418582
closes odoo/odoo#63674
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
| -rw-r--r-- | addons/account/wizard/account_move_reversal.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/account/wizard/account_move_reversal.py b/addons/account/wizard/account_move_reversal.py index a3525107d92..7724ca4475b 100644 --- a/addons/account/wizard/account_move_reversal.py +++ b/addons/account/wizard/account_move_reversal.py @@ -52,7 +52,7 @@ class AccountMoveReversal(models.TransientModel): @api.depends('move_ids') def _compute_from_moves(self): for record in self: - move_ids = record.move_ids + move_ids = record.move_ids._origin record.residual = len(move_ids) == 1 and move_ids.amount_residual or 0 record.currency_id = len(move_ids.currency_id) == 1 and move_ids.currency_id or False record.move_type = move_ids.move_type if len(move_ids) == 1 else (any(move.move_type in ('in_invoice', 'out_invoice') for move in move_ids) and 'some_invoice' or False) |