summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Kersten <jke@odoo.com>2018-08-23 16:51:54 +0200
committerJeremy Kersten <jke@odoo.com>2018-08-24 09:21:46 +0200
commit0cdfc84be862ecefc2eb9f567b2fd5adbf964f85 (patch)
treede09be6d84674c7a5bb24d04d65e743f4d9b6b8c
parentf00f4f385285b12b440b036eaaf87a819541219a (diff)
[FIX] base: fix authentication, wrong login/password raise an error 500
During rebase of 4f6ec1c, we remove accidently a part of aac21e4. Side effect is that uid was False but success_login True. Courtesy of @xmo-odoo for help
-rw-r--r--odoo/addons/base/models/res_users.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/odoo/addons/base/models/res_users.py b/odoo/addons/base/models/res_users.py
index 5a1e3624e4f..067aec82482 100644
--- a/odoo/addons/base/models/res_users.py
+++ b/odoo/addons/base/models/res_users.py
@@ -559,10 +559,11 @@ class Users(models.Model):
self = api.Environment(cr, SUPERUSER_ID, {})[cls._name]
with self._assert_can_auth():
user = self.search(self._get_login_domain(login))
- if user:
- user = user.sudo(user.id)
- user._check_credentials(password)
- user._update_last_login()
+ if not user:
+ raise AccessDenied()
+ user = user.sudo(user.id)
+ user._check_credentials(password)
+ user._update_last_login()
except AccessDenied:
_logger.info("Login failed for db:%s login:%s from %s", db, login, ip)
raise