This commit is a split of the former graphview into a pivot view (the tabular view) and graph view (the various charts). The code was fully rewritten. * pivot view should be faster (better underlying data structure and better algorithm) * better integration with the web client (use of sidebar, of menu buttons, bettor style) * new feature: pivot view can be sorted * new feature: pivot view cells can be clicked to open a list view with the corresponding domain * web_graph addon was removed, and the graph view code has been moved to the addon web. * the interaction with the searchbar was changed (no more column facet) * better and simpler code for graph view * mary corner cases in graph charts have been corrected (for ex, pie chart with positive and negative numbers) * graph/pivot correctly save their state when added to dashboard/saved (state such as current measure, chart mode, column groupbys, ...)
notable: disable the group by integration in graph view, because of crash (the search view was rewritten and too much search logic was in the graph view. This is a temporary measure, the graph view will be split into pivot/graph views, and the search integration will be done correctly in the near future.
the views don't always return a proper promise, or were somewhat fragile and broke with the changes in the view manager.
The group_by query expects the context to have group_by_no_leaf = true, so we can not just blindly forward the context to the groupby query. This is a defensive way to fix the problem, to avoid other possible crashes. But the context shouldn't have group_by_no_leaf anyway, it does not make sense to explicitely do that in the action
the new graph view silently ignored the context when doing its rpc read_group. Usually, it's not really a problem, which is why it is only now being fixed, but some models actually use the context in read_group. (for ex, account_entries_report)
The problem was that when the user manipulates the graph view (in pivot table mode), the graph view resetted the group by facet in the search view. It was not a problem unless a custom filter with a groupby was already there, in which case, the group bys were duplicated. The search view is now smarter, it only resets the additional groupbys (and col_groupbys). Also, to prevent usability problems, the graph view disable the '+/-' groupbys added by a custom filters. Note that this fix is only temporary: a revamp of custom filters, facets, search view is coming in the next months. (at least, that's the idea). Right now, too much 'search logic' is in the graph view. Another note: this fix is somewhat fragile: it makes some assumptions about the search query (mainly that the custom filter is the first facet, also, that no other filters add groupbys/col_groupbys)