Established the proper props validation on the search panel component. closes odoo/odoo#58436 Related: odoo/enterprise#13513 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
closes odoo/odoo#55568 Taskid: 2282495 Related: odoo/upgrade#1574 Related: odoo/enterprise#12272 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Refactoring of the search panel and its inner logic to Owl. The previous search panel widget has been divided in 2 parts: 1. Component The "Search Panel" component's responsibilities are now to render the search panel data given by its model, display some rendering logic (expanded categories, checked groups) and dispatch the events triggered on it. 2. Model Extension The "Search Panel Model Extension" holds all the search logic of the search panel. Its responsibilities are calling the server to update its data and to provide them to its component and other search extensions. Part of task 2228968 Co-authored-by: Julien Mougenot <jum@odoo.com> Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
In the search panel, the categories, i.e. fields select="one", with attributes expand="0", and enable_counters="0" (defaults) were not correctly updated when the domain outside of the search panel was updated. This is no longer the case. closes odoo/odoo#54040 X-original-commit: 99e9cac63f5034c1ba2154779fe82170dd656236 Related: odoo/enterprise#11642 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
The counters for categories were not updated when filter values were selected. This commit fixes that situation. This might impact the global performances of the search panel but there is still room for improvement. Actually, it could be possible to reload categories and filters less often by carefully track the internal changes and the categories/filters attributes (enable counters, expand,...). closes odoo/odoo#49307 Related: odoo/enterprise#9795 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
In the search panel, the domain used to compute the field image values
(when the attribute expand is false) was the same as the domain used
to compute counters (if enabled). The idea was that a value bringing an
empty domain is totally useless and should not displayed.
That being true, it turns out that if one does not allow them and
several fields are used, selecting a value in the search panel will very
often totally transform the search panel. From a UI perspective,
this turns out to be bad: the search panel 'moves'.
Let us give an example:
Let us start from a search panel that looks like to:
first_field
A 1
B 3
second_field
C 1
D 2 <--- mouse above D
E 1
with first_field and second_field both with expand="0" and
enable_counters="1". Let us also assume that no record in the global
domain has both first_field=A and second_field=D.
Click on D would make the search panel look like to something like
first_field
B 1
second_field
C 1
D 2
E 1 <--- mouse here
(the selection of D does not impact the values for the second_field but
does for the other first_field values).
This has led us to use basically only the domain comming from
outside of the search panel to compute field image values.
This means that we might now have value with zero count even if expand
is false. In the above situation, a click on D would give us
first_field
A
B 1
second_field
C 1
D 2 <--- mouse still above D
E 1
Task ID: 2154749
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
This commit introduces a new attribute 'limit' for search panel fields that allows to avoid performance issues. That integer attribute (with default 200) allows to fix a maximal number of values to display for the fields. When the number of field values to display reaches the limit, no values will be displayed. Instead, a warning message will be shown in the corresponding search panel section. Note it is possible to have no limit using limit="0" on a field. This commit reintroduces in a better way the principle brought by the fix 8d57153b34c04952a85f6642951cb2697016da84. Task ID: 2154749
The commit introduces two new attributes for search panel fields:
- hierarchize: boolean attribute (default True) available for
many2one fields with select="one". It allows to choose whether
to hierarchize the field values using the _parent_name (if set)
on the field comodel.
Note that a sanitization of the parent hierarchy takes place.
Basically, it ensures that parent chains are
completely in the domain (on comodel) accessible by the user.
See _search_panel_sanitized_parent_hierarchy documentation for
more information.
- expand: boolean attribute (default False) available for many2one
and many2many fields. If set to true, all field values are fetched
and displayed in the search panel. If set to false, only the
values that have at least one corresponding value in the field
model (and in some domain) are fetched.
An exception in the case of an hierarchized field
(hierarchize=True and _parent_name set): more/less values can be
displayed in order to have a good representation of the parent
hierarchy. That means we complete and sanitize the set of initial
field image values.
Note that the fix 8d57153b34c04952a85f6642951cb2697016da84 bringing the
notion of limit in search panel has been reverted in the present commit.
An upcomming commit will reintroduce the limit principle in a better way.
Task ID: 2154749
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
In the search panel, the attribute disable_counters with default False has been changed to enable_counters with default False.
1) Clicks on a section value are now bound to the entire header, meaning that the sole purpose of the carets is purely esthetic. 2) Search panel categories will now only be folded if they are being clicked on while already selected. Classes that were no longer useful have been removed and tests have been updated accordingly. Task 2264700 closes odoo/odoo#51555 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>