Courtesy of Transifex's translators for reporting bad/unclear sentences. closes odoo/odoo#61785 Related: odoo/enterprise#14751 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Courtesy of translators Reexport .pot of modified modules closes odoo/odoo#61002 Related: odoo/enterprise#14485 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Mainly transifex issues but also some errors found through 'grep' checks. Fix typos and obscure english strings in xml contents, fields strings/helps, some docstrings, ... ensuring correct translations base (and fallback when translations isn't available). closes odoo/odoo#57206 Related: odoo/enterprise#13032 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Our CSRF tokens are based on the current user session, and automatically expire as soon as the session does. However, they also come with a default 1h expiration delay. This proves to be a frequent annoyance for users who pause more than 1h on a form before submitting it (e.g. user logs out and browser sits on login page until the next day). It can even lead to blocking bugs, e.g. when the 1h expiration occurs in the middle of taking a survey exam, and the user is never able to post the answers that are only present in the state of the form they need to post. More generally, users have a hard time understanding those CSRF expiration errors, and don't know how to react. Longer default expiration times have been considered (e.g. 1 day or 1 week) but those would not bring any identified benefit in terms of security, while still giving a chance that some users would experience the incomprehensible HTTP 400 errors). Attacks that can typically compromise the CSRF token (XSS, RCE) can achieve as much, or more, on the system or user account than what is possible with the token. And nothing generally prevents the attacker from using the token immediately after capturing it, during the initial attack, making the expiration delay rather irrelevant. Given there seems to be no significant benefit in expiring the tokens before the session itself, let's just keep them valid as long as the session. Note: sessions are GC'd automatically after 7 days of inactivity, which gives an effective 1 week expiry for abandoned web forms anyway, as the token expires with the session. Additionally, fix `survey` module tests, that were using an incorrect regex for extracting CSRF tokens. closes odoo/odoo#51499 Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Issue
- Install Survey & Contacts
- Have 2 contacts with the same email address
(e.g. test@example.com)
- Create a survey, send it only to that
email address
Email sent 2 times
Cause
When looking for partners linked
to that email address, we do not
provide any limit so the system
send the email to all partners
found.
Solution
If I set one email address,
I expect one email to be sent.
So, the solution would be to
apply a limit of 1 when login
is not required.
OPW-2247693
closes odoo/odoo#51155
X-original-commit: 55b1cc3108d6b672f10ece26db7e13a65ff655d3
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Purpose of this commit is to clean test that broke nightly recently. Task ID closes odoo/odoo#49759 X-original-commit: 61f9b05ccc61a7e00dc5cc43cb1f8196195bee60 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of this commit is to synchronize active status of certifications to their badges. When archiving or activating a certification, its badge is also archived or activated. Task ID 2170708 Community PR odoo/odoo#46563
PURPOSE This commit adds a big flow test/tours to the survey sessions, for the host point of view. This will avoid breaking the feature with future changes, as it contains some tricky and complex mechanics (especially the screens chaining). SPECS The tour tests the whole host point of view. Break down of the testing/tour main points: - Create the survey session - Check our attendees are accounted for - Open the 'session manager' - Display the nickname question, and move to the next one (as answers are not displayed for nickname questions) - Check answers are correctly displayed for the 3 'simple' question types (text, date, datetime) - Move to the choice question and check that answers are displayed - If everything is correctly displayed, move to the next question - On the scored choice question, check that the screens are correctly chained: no results displayed -> results displayed -> correct/incorrect answers -> leaderboard - On the scored + timed multiple choice question, check the same than previous question, except that the results are supposed to be displayed automatically when the question timer runs out - Test the 'back' behavior and check that screens are reversed correctly - Check that our final leaderboard is correct based on attendees answers - Close the survey session LINKS PR #46768 Task 2208574
Notably
* have tools and helpers in a SurveyCase and let SurveyCommon bet the
one with data;
* remove unnecessary with_user, replaced by standard one;
* move all tools in SurveyCase to help reusing them;
When a random survey does not use all the questions available in a page because of the random_questions_count field, _get_answers_correctness was still including them in the skipped category. This commit ensures that those questions are not included in the result, and adds a test that checks it. closes odoo/odoo#47362 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> X-original-commit: 4df43478979766112ae70624deae9c25f40a3349