Odoo/addons/sms/models/sms_sms.py, branch 14.0 The current checkout of upstream Odoo [IMP] sms: do not copy error 2020-08-07T16:46:19+00:00 Swapnesh Shah swapneshshah111@gmail.com 2020-08-07T16:46:19+00:00 a49e38879fd9f0dce6940c86766e01fdc7374fa6 Error message should not be copied for obvious reason. closes odoo/odoo#55644 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> 
Error message should not be copied for obvious reason.

closes odoo/odoo#55644

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
[IMP] sms: Add new failure status for unregistered accounts 2020-05-12T16:39:40+00:00 Rémi Rahir rar@odoo.com 2020-03-27T17:28:03+00:00 7287800101ba6d054960b906da3a5a538abcb02f Since January 2020, users are required to validate their IAP account via SMS code validation. This new behaviour needed to be properly ported to the client to correctly inform the user. This commit adds support of a new failure_type: 'Unregistered Account'. Task #2209567 closes odoo/odoo#48512 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> 
Since January 2020, users are required to validate their IAP account via
SMS code validation. This new behaviour needed to be properly ported to
the client to correctly inform the user.

This commit adds support of a new failure_type: 'Unregistered Account'.

Task #2209567

closes odoo/odoo#48512

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
[IMP] mail, sms, snailmail, test_mail_full: adapt mail.notification 2020-04-17T12:17:57+00:00 Sébastien Theys seb@odoo.com 2020-04-17T09:53:05+00:00 dea52493b819939ae16391d8b19c2f404c7ec143 The purpose is to have more common code for failure and notifications, with less override in `sms` and `snailmail`. task-2176017 closes odoo/odoo#44170 Related: odoo/enterprise#9140 Related: odoo/upgrade#918 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> 
The purpose is to have more common code for failure and notifications, with less
override in `sms` and `snailmail`.

task-2176017

closes odoo/odoo#44170

Related: odoo/enterprise#9140
Related: odoo/upgrade#918
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
[FIX] sms: set correct value of batch when contacting IAP sms 2019-09-25T11:12:51+00:00 Thibault Delavallée tde@odoo.com 2019-09-24T12:17:22+00:00 31aa195efa912eb315af62a22ad83fe83d25d5cb Batch of 10 text messages was ok for testing. Production environment should be able to handle more of them. LINKS Task 2076366 (send now) Task 2067873 (template access) PR #37298 PR odoo/enterprise#5750 
Batch of 10 text messages was ok for testing. Production environment should
be able to handle more of them.

LINKS

Task 2076366 (send now)
Task 2067873 (template access)
PR #37298
PR odoo/enterprise#5750
 [FIX] sms: number is actually not really required 2019-09-20T13:44:09+00:00 Remy Voet ryv@odoo.com 2019-09-20T13:03:51+00:00 428da3d539eb3dd77b0e1c20d86c283194ef0917 sms, in the form view of sms composer (mass composition) : we got a blocking message when we validate the composer sms with records which doesn't have a phone number. However we generally explicitly handle void numbers: in composer in comment mode there is an User Error, and mass mode has specific error code to put on sms records telling number is void (and sms is in error, meaning it will not) be sent. As sms record is required notably for mass mailing traces and marketing automation traces we have to keep sms records with void numbers. We therefore remove the required attribute on sms record. Task ID 2073016 (sms fixes) PR #37185 
sms, in the form view of sms composer (mass composition) : we got a blocking
message when we validate the composer sms with records which doesn't have a
phone number.

However we generally explicitly handle void numbers: in composer in comment
mode there is an User Error, and mass mode has specific error code to put on
sms records telling number is void (and sms is in error, meaning it will not)
be sent.

As sms record is required notably for mass mailing traces and marketing
automation traces we have to keep sms records with void numbers. We therefore
remove the required attribute on sms record.

Task ID 2073016 (sms fixes)
PR #37185
 [FIX] sms - mass_mailing: fix some bugs 2019-09-12T14:53:44+00:00 ryv-odoo ryv@odoo.com 2019-09-05T14:41:11+00:00 8ef1543908b482820186f60a976bc44808b0c600 - Cancel button in the sms form view not related to a action : When we click on the cancel button of the sms form view, get traceback. Fix the issue by adding the cancel action in sms model. - Mass mailing contact - False as the display name : The display name was the mail address but when the contact didn't have mail address a ugly False was print to described the contact (form view). Then change the _rec_name to print the name as the display name. - Fix SMS composer for the res.parnter tree Only the first record was truely selected when open the sms composer (mass) from the tree view of partner. Fix that by bind the actives_ids in the context and also fix the names of related actions. TASK_ID : 2053631 
- Cancel button in the sms form view not related to a action :
When we click on the cancel button of the sms form view, get traceback.
Fix the issue by adding the cancel action in sms model.

- Mass mailing contact - False as the display name :
The display name was the mail address but when the contact didn't have
mail address a ugly False was print to described the contact (form view).
Then change the _rec_name to print the name as the display name.

- Fix SMS composer for the res.parnter tree
Only the first record was truely selected when open the sms composer
(mass) from the tree view of partner. Fix that by bind the actives_ids
in the context and also fix the names of related actions.

TASK_ID : 2053631
 [REF] sms: improve onboarding and user experience of SMS composer 2019-08-12T12:00:22+00:00 Thibault Delavallée tde@odoo.com 2019-08-05T15:56:21+00:00 5450415354233671fe42f62c3b095d03c1389317 PURPOSE SMS are a powerful marketing tool. For instance it is perfect to announce a sale or to communicate a coupon code, to welcome a new customer in a fidelity program, ... Purpose of this task is to integrate SMS sending in batch in mass mailing. It will use same mailing objects but sending SMS instead of emails. Some metrics and flows will have to be slightly updated at the same time. SPECIFICATIONS Clean the use and options of sms composer after FP feedback : * see https://s.nimbusweb.me/share/3167586/ap1xpy95rz29a5cys576 as basis; * globally, do not display invalid recipients, only valid / invalid count as well as current selection / active domain counts; * consider logging a note as default behavior when using the composer; * simplify code: when doing a mass SMS, send SMS and attach a simple note to the document; Some other points * make name of sms templates translatable; * improve various wording, notably in sms widget; * display error code in sms list view; * update sms composer actions accordingly by correctly setting active id or ids; LINKS Task 1997464 PR #34424 Original SMS addition: Task 1922163 (4287481) 
PURPOSE

SMS are a powerful marketing tool. For instance it is perfect to announce a
sale or to communicate a coupon code, to welcome a new customer in a fidelity
program, ...

Purpose of this task is to integrate SMS sending in batch in mass mailing. It
will use same mailing objects but sending SMS instead of emails. Some metrics
and flows will have to be slightly updated at the same time.

SPECIFICATIONS

Clean the use and options of sms composer after FP feedback :

  * see https://s.nimbusweb.me/share/3167586/ap1xpy95rz29a5cys576 as basis;
  * globally, do not display invalid recipients, only valid / invalid count
    as well as current selection / active domain counts;
  * consider logging a note as default behavior when using the composer;
  * simplify code: when doing a mass SMS, send SMS and attach a simple note
    to the document;

Some other points

  * make name of sms templates translatable;
  * improve various wording, notably in sms widget;
  * display error code in sms list view;
  * update sms composer actions accordingly by correctly setting active id
    or ids;

LINKS

Task 1997464
PR #34424
Original SMS addition: Task 1922163 (4287481)
 [IMP] sms: integrate duplicate / blacklist into composer in batch mode 2019-08-12T12:00:22+00:00 Thibault Delavallée tde@odoo.com 2019-07-26T11:43:55+00:00 5d1f08a01289375acbe44c2f33d95869477cdb1e PURPOSE SMS are a powerful marketing tool. For instance it is perfect to announce a sale or to communicate a coupon code, to welcome a new customer in a fidelity program, ... Purpose of this task is to integrate SMS sending in batch in mass mailing. It will use same mailing objects but sending SMS instead of emails. Some metrics and flows will have to be slightly updated at the same time. SPECIFICATIONS Purpose of this commit is to support blacklisted and already-done numbers when sending SMS. * blacklist support: necessary to avoid sending SMS in batch to people that asked to stop being spammed; * already-done support: when performing mailing in batch or doing A/B testing we may have already-done SMS; When sending SMS in batch, already update state and error code of SMS that should not be sent * blacklisted number: set to canceled, with blacklist error code; * duplicated number: set to canceled, with duplicated error code; * invalid number (cannot sanitize): set to error, with either missing number if void or wrong format if not void; Support of blacklist / duplicated / invalid will notably be used when performing SMS marketing (mass SMS) and marketing automation using mass SMS. LINKS Task 1997464 PR #34424 Original SMS addition: Task 1922163 (4287481) 
PURPOSE

SMS are a powerful marketing tool. For instance it is perfect to announce a
sale or to communicate a coupon code, to welcome a new customer in a fidelity
program, ...

Purpose of this task is to integrate SMS sending in batch in mass mailing. It
will use same mailing objects but sending SMS instead of emails. Some metrics
and flows will have to be slightly updated at the same time.

SPECIFICATIONS

Purpose of this commit is to support blacklisted and already-done numbers
when sending SMS.

  * blacklist support: necessary to avoid sending SMS in batch to people that
    asked to stop being spammed;
  * already-done support: when performing mailing in batch or doing A/B testing
    we may have already-done SMS;

When sending SMS in batch, already update state and error code of SMS that
should not be sent

  * blacklisted number: set to canceled, with blacklist error code;
  * duplicated number: set to canceled, with duplicated error code;
  * invalid number (cannot sanitize): set to error, with either missing number
    if void or wrong format if not void;

Support of blacklist / duplicated / invalid will notably be used when
performing SMS marketing (mass SMS) and marketing automation using mass
SMS.

LINKS

Task 1997464
PR #34424
Original SMS addition: Task 1922163 (4287481)
 [FIX] sms: update and fix returned IAP state about badly formatted numbers 2019-07-23T08:29:15+00:00 Remi Rahir rar@odoo.com 2019-07-22T09:35:19+00:00 4968eb7c831cd227869273dc22de20578c830a93 PURPOSE Followup of merge 4287481 . SPECIFICATIONS wrong_format_number is actually now called wrong_number_format. This commit propagates this renaming through SMS code and tests. LINKS Task 1922187 closes odoo/odoo#35025 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> 
PURPOSE

Followup of merge 4287481 .

SPECIFICATIONS

wrong_format_number is actually now called wrong_number_format. This commit
propagates this renaming through SMS code and tests.

LINKS

Task 1922187

closes odoo/odoo#35025

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
 [FIX] mail, sms: post sms message as a note on related document and apply various fixes 2019-07-18T09:20:06+00:00 Thibault Delavallée tde@odoo.com 2019-07-18T08:34:23+00:00 2b7ad217f1a55a0687ba4ec4765bc7777114aac0 PURPOSE Improve use of SMS. Followup of merge 4287481bf03fbb6539313ff657af0ca58e2895e7 . SPECIFICATIONS Currently when sending an SMS through the UI a message is posted using the comment subtype. However it is better to lessen number of notifications and log using the note subtype as it is mainly a log to know something has been sent. Order SMS by ID desc to ease finding them in technical menu. Mail, sms: fix wording of mail / SMS failures Linked to task 1925950 and 1935280 Part of PR #34864 
PURPOSE

Improve use of SMS. Followup of merge 4287481bf03fbb6539313ff657af0ca58e2895e7 .

SPECIFICATIONS

Currently when sending an SMS through the UI a message is posted using the
comment subtype. However it is better to lessen number of notifications
and log using the note subtype as it is mainly a log to know something has
been sent.

Order SMS by ID desc to ease finding them in technical menu.

Mail, sms: fix wording of mail / SMS failures

Linked to task 1925950 and 1935280
Part of PR #34864