TL;DR ===== Improve performances with nearly a factor of 2. Use case, call action_validate on hr.leave for 100 employees - 1987 requests -> 844 requests - 1300 ms -> 700 ms Purpose ======= The first purpose of this commit is to add a test ensuring the number of request while creating a company leave for 100 employees, if 15 of them already have a leave during that period. It includes, the mass leave generation, and the conflicts resolutions. (Cancelling/Splitting the already existing one and adapting the dates accordingly). The second one is to reduce the number of request for this test. In term of requests, currently we have: - 5154 requests without bypassing the mail tracking + the activities management - 1987 requests when bypassing the mail post-process (this is the current value, the bypassing was already done several month ago) - 844 requests with all the optimization done in resource/calendar/hr_holidays In terms of execution time, we have a reduction from +- 1300 ms to call the method action_validate to +- 700 ms As the performances issues severity increases with the number of leaves to create and the real time access to the database, on the production base, we reduced the execution time to generate more than 500 hr.leaves from several minutes to 21 seconds. A fix to avoid deadlock was already made at https://github.com/odoo/enterprise/pull/10740/files Some contortions were made to avoid changing a signature method in a stable release and thus introducing for each method a second one, with the "batched" implementation, to keep a retro-compatibility for the existing custom code. But surely this could be cleaned in the master version. The old one will be deprecated while waiting to be removed in a few versions. closes odoo/odoo#56477 Taskid: 2256705 X-original-commit: 8820db912f9e8ca71a57d3b0d32d2020d35b963f Related: odoo/enterprise#12642 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
With a user with timezone "Europe/Brussels", add a slot on the gantt view where the preceding day is a working day. The default starting time will be the previous day. Reason: the default starting time is midnight, adjusted to the closest attendance interval in the employee's calendar. However, midnight in "Europe/Brussels" is actually 10pm UTC the previous day. The method adjusting the datetime to the closest attendance only checks within the corresponding day. Two ways to fix this: 1) the business code calling `_adjust_to_calendar` should timezone the datetimes itself. To avoid similar bugs in the future, the method should be modified to only accept timezoned datetimes. 2) Change `_adjust_to_calendar` to convert datetimes it was given to the resource's timezone and consider the dates in those converted datetimes. Option 2 is chosen because it seems to take care of the problem at a lower level which allows the business code to not think about those timezone details. While this is technically an API change (in a stable release), the method was introduced recently by b058ca1 as a fix for an already broken method. closes odoo/odoo#53582 X-original-commit: c6cecac60360a1d8b0c62ee155a818a3a28505e1 Related: odoo/enterprise#11399 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
The method `_get_work_interval` has several problems: 1) The name is not self explanatory in any way 2) It should be defined on the `resource.mixin` 3) It simply does not work (as described in its docstring). Here is a simplified example (only concerned about hours): Currently, given two attendances: 8-12 and 13-17, with parameters start=9 and end=18 it returns (9, 17) while it should return (8, 17). This leads to strange behaviors in the planning app: Given employee A with calendar 8-17 and employee B 8-16. Create a planning slot and assign employee A: the start and end times are set to 8-17. Then assign employee B, the start and end times are correcly set to 8-16. Now reassign employee A: the start and end times are not set to 8-17. Task 2229296 closes odoo/odoo#50804 X-original-commit: 7dfab89bc0025cf6424f00b6992fef1f42463ffe Related: odoo/enterprise#10426 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>
Purpose ======= In Belgium, we need to support some partial time on 2 weeks. For instance, a mid time, means you could work on monday, tuesday and wednesday on week1 and monday and tuesday on week 2. Others payroll softwares manage this. Specification ============= Add a checkbox on resource calendar to manage 2 weeks. --> Consider even/odd weeks. Add sections on calendars (Like sales orders) Modify methods in resources to apply this behavor generically. Check that attendances aren't overlapped Write an integration test for holidays - benefits - payslip to check all this, + "credit temps" and wage modification. Note ==== For the sake of simplicity, we only manage calendars over 2 weeks to consider the odd/even weeks and keep an easy implementation. For more complicated calendars (eg: over a months with specific targetted days), it's better to create specific allocation requests and apply specific leaves for those days, as it would be the case for parental leaves. closes odoo/odoo#31674 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose ======= Buggy example: I have a 35h working schedule. I work every week day: - From 8h to 12h - From 12h to 16h Let's say that I want to retrieve the working hours from Wednesday 14h03 to Thursday 11h03. The working hours are: - From 14h03 to 16h --> 1h57 - From 8h to 11h03 --> 3h03 ---------------------------- TOTAL 5h Currently the result will be 1.95, i.e. 1h57 because the second day is not taken into account as start time > end time, and thus rrule doesn't manage this correctly and returns only the datetime corresponding to the first day. Specification ============= Force the until parameter of rrule to be set at the end of the day, do avoid skipping the second day. Do this in the methods that compute the work hours and the leave hours. Add a test to ensure the robustness of the fix. Closes #21297 closes odoo/odoo#28920
In order to be more precise in the number of hours shown in leaves, we need more precision in resource_mixin closes odoo/odoo#28907