Odoo/addons/project/models/project.py, branch 14.0

[FW][FIX] mail, various: fix document access link computation

2021-04-23T08:00:43+00:00

Purpose of this commit is to fix computation of access link. In some cases
msg_vals modification leads to invalid URL computation, notably for frontend
or backend differentiation for target recipients.

Followup of odoo/odoo#63292 .

Task ID-2513724
COM PR odoo/odoo#69607
ENT PR odoo/enterprise#17849

X-Original-Commit: odoo/odoo@2015ef463c9ac7c7f89d543745c02a2d1528acf2

[FIX] project: Creating project via service product deletes contact's data

2021-02-18T11:50:52+00:00

Steps to reproduce the bug:

- Let's consider a customer C1 with email address A1 and phone P1
- Let's consider a project PR with C1 as customer
- Let's consider a service product P with:
   - Milestones (manually set quantities on order) as Service Invoicing Policy
   - Create a new project but no task as service tracking
   - PR as project template
- Create a sale order SO with C2 as customer with A2 as email address and P2 as phone
- Confirm the SO

 Bug:

 The email address and phone of C2 were changed into A1 and P1 instead of keeping A2 and P2

 opw:2439459

closes odoo/odoo#66307

Signed-off-by: Simon Goffin (sig)

[FIX] project: filter when not required

2021-02-02T11:04:49+00:00

Before this commit:

A method action_subtask is including the other actions context if have which
reflects while clicking on the Sub-tasks stat button. For examples:

- When click on the stat button 'Sub-tasks' of any task which one is clicked by
  systray activity icon results
- When click on the task menu in project there a default search filter 'My task'
  which also passes when click on 'sub tasks' stat button

After this commit:

Remove the context that startswith `search_default'.
Hence, now subtask will display with the correct context.

Task-2413127

closes odoo/odoo#65395

Signed-off-by: Yannick Tivisse (yti)

[FW][FIX] project: propagate internal subtypes to tasks

2021-01-19T16:33:22+00:00

before this commit:

while changing subtypes of the project it was only
propagating those subtypes to the task, whose parent_id is set.
internal subtypes are not propagating in the task of a project.

So, filter internal subtypes and concat them with the subtypes which
have parent_id.

after this commit:
internal subtypes will also propagate to their tasks

closes odoo/odoo#62495

X-original-commit: odoo/odoo@2ad320e9050160725601b82fa6239c94aad93d20
X-original-pr: odoo/odoo#47336
Signed-off-by: Thibault Delavallee (tde)

[FIX] project: remove dependency cycle in compute method

2021-01-13T11:29:26+00:00

The issue was triggered by the fact that editable fields are no longer
computed when they have a default value.

closes odoo/odoo#64359

Signed-off-by: Raphael Collet (rco)

[FIX] mail: send notification mail with right access link when using mail.thread

2021-01-06T17:03:53+00:00

PURPOSE

Notification may be sent using a generic mail.thread record, notably when
sending user notifications. In that case links to view document are
incorrect.

HOW TO REPRODUCE

Issue

    - Install "Approvals"
    - Submit new approval with you as "Request Owner"
    - Click on "View Approval Request" in your mailbox

    The link redirects to a 505 error

Cause

    The model is not the correct one and the res_id is undefined

Solution

    Specify the model and the res_id to _notify_get_action_link
    when creating the link with kwargs

SPECIFICATIONS

Propagate message value through various notification sub methods. That way
we can rely on them if model seems void.

Also limit values given as URL parameters to some white listed values.

LINKS

opw-2358846
Task ID-2379766
Followup of odoo/odoo#60998
Followup of odoo/odoo#61545
Closes odoo/odoo#63292
Closes odoo/enterprise#15585

closes odoo/odoo#64170

X-original-commit: 2b6d2b71f6c60bcf64db440473c88d1dc335acbf
Related: odoo/enterprise#15588
Signed-off-by: Thibault Delavallee (tde) 
Co-authored-by: Achraf Ben Azzouz 
Co-authored-by: Thibault Delavallée

[FIX] project: Fix wrong recipient display based on email_from

2020-12-08T15:32:57+00:00

Currently, The customer that is not selected anymore is suggested
as a recipient

steps to reproduce:
1. create a project task without a customer set
2. select a customer, then remove it, then save
3. send a message in the chatter
--> the customer that is not selected anymore is still suggested as
a recipient.
The issue is due to invalid value of partner's email in the field
email_from on task.

So in this commit, when the customer is not defined or is not a child
task then keep the email_From of the task.
(Here we are checking the task.parent_id because when someone update
the email_from on parent it should be updated in child task's
email_from and when we remove the email_From in parent it should not
be removed from child task)

closes odoo/odoo#63042

Taskid: 2339894
Signed-off-by: Yannick Tivisse (yti)

[FIX] project: show "View Task" to portal customers

2020-11-27T09:05:25+00:00

Since commit 62024ca the portal customer of a task were missing the
"View Task" button.

closes odoo/odoo#62484

Taskid: 2393286
Signed-off-by: Yannick Tivisse (yti)

[FIX] project: don't send rating email when disabled on project

2020-11-23T08:44:52+00:00

The rating emails were still sent even if the rating feature was
disabled on the specific project.

This commit ensures the emails are only sent to project with the feature
enabled.

closes odoo/odoo#62145

Taskid: 2390802
Signed-off-by: Yannick Tivisse (yti)

[FIX] *: rephrase, correct typos

2020-11-16T14:35:42+00:00

Courtesy of Transifex's translators for reporting bad/unclear sentences.

closes odoo/odoo#61785

Related: odoo/enterprise#14751
Signed-off-by: Martin Trigaux (mat)