Odoo/addons/point_of_sale/models/pos_order.py, branch 14.0

[FIX] point_of_sale: cash rounding on invoice

2021-05-28T09:04:23+00:00

When an invoice is created from pos having a cash rounding method, the
value of the rounding can depend on the payment methods.

When no rounding has been applied because of the order has been
partially paid by cash and bank, the rounding line should be deleted
from the invoice. We should also adapt the terms lines.

closes odoo/odoo#71375

Signed-off-by: pimodoo

[FIX] point_of_sale: create only one picking when validating order (if the option is activated)

2021-04-30T11:58:37+00:00

closes odoo/odoo#70154

Signed-off-by: pimodoo

[FIX] pos_cash_rounding: fix when multiple payment method

2021-04-21T09:48:23+00:00

When a pos user combines payment methods with and without rounding, we
must be sure that the rounding is made by payment method and not only on
the total amount of the order.

As the total may change depending on the combination of payment method
used, we had to adapt the methods that checks that an order is paid, and
also propagate the new rounding made on the invoice.

We also don't allow anymore a user to validate an order with a payment
badly rounded.

closes odoo/odoo#69544

Signed-off-by: pimodoo

[FIX] pos_cash_rounding: fix cash rounding for cash method only

2021-02-01T12:11:35+00:00

- Go to Point of Sale > Configuration > Settings & enable "Cash Rounding"
- Configure POS:
  * Enable Invoicing
  * Enable "Cash Rounding" and "Only on cash methods"
  * Select 0.05 HALF-UP Rounding Method
- Start POS session
- Select a Product and change its Price to a value that should be rounded (i.e. $ 16.51)
- Select a Customer
- Proceed to Payment
- Enable Invoice
- Select Bank Payment method
- Validate
No rounding is applied as expected, but the rounding line still appears on printed Invoice.

opw-2449222

closes odoo/odoo#65317

X-original-commit: b0eb0fe06a3a9946d2565c6f9efe67f760a3837f
Signed-off-by: pimodoo 
Signed-off-by: Anh Thao PHAM

[FIX] point_of_sale: respect setting only_round_cash_method

2021-01-08T15:02:19+00:00

STEPS:
* configure rounding:
  - cash_rounding=True
  - only_round_cash_method=True
  - round method: 1.0 Down

* open a session
* add products with subtotal in decimals (such as 6.35)
* select Bank payment method and process the order

BEFORE: error "You have to round your payments lines"

AFTER: order is processed and marked as paid

---

https://github.com/odoo/odoo/commit/42425996e36d9cb1fc1391402cf6d00df4aea019
opw-2426027

closes odoo/odoo#64270

Signed-off-by: pimodoo

[FIX] point_of_sale, pos_sale: Field crm_team_id not defined

2020-12-31T14:14:20+00:00

Fine tuning of https://github.com/odoo/odoo/commit/61e5389236ad767827ef2fe039aa78b20848298e

opw:2418806

closes odoo/odoo#63939

Signed-off-by: Simon Goffin (sig)

[FIX] point_of_sale: Sales Team set on POS didn't appear on invoice

2020-12-28T13:11:34+00:00

Steps to reproduce the bug:

- Let's consider a sales team ST and a POS session PS
- Set ST on PS
- Open PS and make an invoice I from an order

Bug:

The sales team set on I was not ST

opw:2418806

closes odoo/odoo#63831

Signed-off-by: Simon Goffin (sig)

[FIX] *: sanitize action content reading

2020-11-10T10:47:14+00:00

The open_action_with_context was not using _for_xml_id, producing an
error when reading the action content.

In open_action, the action_name was taken from the context and needs
sanity checks. Ensure only actions from the account module can be
read and only if the user has access to the target model.
This is a limitation of the previous behaviour but, at the moment, all
known calls are made refering to an action from the account module.
Limit the scope of this method while the 14.0 is still early to avoid
having a door open to ready any action, and difficult to close later.

Remove old action fetching from the context in create_move that is no
longer used.

closes odoo/odoo#61365

Related: odoo/enterprise#14682
Signed-off-by: Martin Trigaux (mat) 
Co-authored-by: Xavier Morel

[FIX] point_of_sale,pos_sale: currency_rate more digits

2020-10-14T15:58:05+00:00

In 857c4851754 currency_rate precision was changed to keep more digits
for the currency rate.

This commit reflects that in the point of sale.

Also this change fixes an update issue that could recreate sale.report
uncomplete because:

=> point_of_sale and pos_sale had different definition of
   pos.order().currency_rate field

=> this caused the field to be recreated (to change from double precison
   to numeric) on a given module update (pos_hr)

=> this caused the sale.report view to be dropped

=> this caused the sale.report view to be recreated before modules (that
   added fields to sale.report) were fully loaded

opw-2306523

closes odoo/odoo#60027

X-original-commit: a73030b3d71d835145b01b81515a21e23187687c
Signed-off-by: Nicolas Lempereur (nle)

[FIX] point_of_sale: unable to close open session with deleted journal

2020-10-05T11:03:43+00:00

Steps to reproduce the bug:
- Create POS (P)
- Create journal (J) and link it to (P)
- Open a new session in (P)
- Exit the session without closing it
- Delete (J)

Bug:
You cannot close the session nor assign a new journal to the POS.

opw:2347169

closes odoo/odoo#59090

X-original-commit: 636f1358e72e65a3210c95c60d1703c9cbd914dc
Signed-off-by: Nicolas Martinelli (nim) 
Signed-off-by: backspac