Odoo/addons/payment/static/src/js/payment_form.js, branch 14.0

[FIX] payment: enable pay button when clicking back button

2021-05-17T07:30:17+00:00

Issue

    Use Safari (or equivalent) browser

    - Install e-commerce
    - Go to Website -> Configuration -> Payment Acquirers
    - Activate Ingenico in test mode
        (write aaa in required fields)
    - Go to shop, and add product to card
    - Go to checkout
    - Select Ingenico payment mode
    - Click on Pay button
    - When on the ingenico page, press back

    The page is blocked and the button is disabled.

Cause

    When clicking on Pay button, the page is locked and
    the button is disabled.
    With Chrome, when coming back to previous page,
    this one is regenerated and therefore adapt the button.
    In Safari, it is not the case.

Solution

    On `pageshow` event, if event have `persisted` attribute set to
    to true, meaning using cache, then reload page.

Fixes https://github.com/odoo/odoo/issues/69453

opw-2510281

closes odoo/odoo#70834

X-original-commit: f2eb6d3ce8b31d3f14f45482060d4ef5c362e7c3
Signed-off-by: Romain Derie 
Signed-off-by: Jérémy Kersten (jke) 
Signed-off-by: bon-odoo

[FIX] payment: fix ecommerce blinking "Pay now" button

2021-04-09T15:14:10+00:00

Missing line in forward-port of 12.0 #41860 (88b37c2b1).

If a server error happen when we try to pay (eg. there is not enoug
quantity of a product), the page is forever freezed and the user only
option is to refresh which is not user friendly.

opw-2438379

closes odoo/odoo#69062

X-original-commit: 38fb1c2e3f4dd48fc177b1b2b37a2eba4bd27018
Signed-off-by: Nicolas Lempereur (nle)

[IMP] payment: allow overriding the redirect form HTTP method

2021-03-23T15:05:18+00:00

closes odoo/odoo#68250

X-original-commit: 923eaae31b0993d8a7e653b334471f7b6289450f
Signed-off-by: Antoine Vandevenne (anv)

[FIX] payment: link transaction to invoice with payment link

2021-03-04T18:09:37+00:00

Steps:
- Install account,payment
- Go to Invoicing
- Create an invoice
- Click Actions > Generate a Payment Link
- Follow the generated link
- Pay

Bug:
The transaction is not linked to the sale order in the link table
`account_invoice_transaction_rel`

Explanation:
This fix is broadly mimicking the behavior of the sales module regarding
the link of an order to a transaction, adding `invoice_id`s where they
are needed throughout the payment process in order to link the
transaction to the invoice.

opw:2451534

closes odoo/odoo#67289

X-original-commit: 7c6d06fa5858f79f3b22cdeaf74cdc26a642742f
Signed-off-by: Nicolas Lempereur (nle) 
Signed-off-by: backspac

[IMP] payment, payment_test: missing payment token identifier

2020-11-17T11:41:14+00:00

Before this commit payment tokens had no name for Test Payment Acquirer

After this commit tokens generated by Test Payment Acquirer have a name
that combines the last 4 digits of the card number and the card account
holder name

https://github.com/odoo/odoo/issues/50965

closes odoo/odoo#61844

X-original-commit: e20f0650acbd1a7a918375a70ec5c89606523a7b
Signed-off-by: Jérémy Kersten (jke)

[FIX] payment: prevent changing checkout options

2020-11-13T14:11:51+00:00

STEPS:

* install website_sale
* setup few delivery options
* setup online payment (e.g. paypal)
* at website add products to cart and proceed to checkout page
* slow down internet speed
* click "Pay now"

BEFORE: while it's loading, you can change delivery option. So, you have SO
changed, while in payment page you see old total amount

AFTER: it's not possible to change delivery options through UI

Note that it is not possible to pay less that what you should at anyway.

opw-2324543

closes odoo/odoo#61721

X-original-commit: eb3ed89f8440050fc32f9a7b29fb2b6ab8fd6b59
Signed-off-by: Romain Derie 
Co-authored-by: Romain Derie

[FIX] payment: User can pay without selecting a delivery method

2020-10-20T10:19:20+00:00

Issue

	- Install "eCommerce" and "Inventoy"
	- Activate "Fedex" delivery connector in settings
	- Publish "Free Delivery" and "Fedex US" delivery method
	- Put the "FedEx" one above the "Free Delivery"
	- Go to shop and add an item to cart
	- Set an adress with no ZIP code and checkout
	- Select a payment methode and pay

	Order is generated without selecting a delivery method
	Same behavior happend when using only "Fedex" as delivery
	method.

Cause

	The flow make the `payment.payment_form` trigger start after
	`website_sale_delivery.checkout` JS module.
	In 'start' function of `payment.payment_form`, the `disabled`
	attribut is removed from button if no checkbox_cgv is present
	and therefore break the `disabling` managemet since
	`disabledReasons` payButton data are not sync anymore.

Solution

	Remove 'disabled' attribut only if has `disabledReasons` data on
	payButton (checkbox_cgv feature alter `disabledReasons`).

opw-2355407
opw-2357605

closes odoo/odoo#60355

X-original-commit: 04e589e80b3ef48640f275cb20d31c17c2126c69
Signed-off-by: bon-odoo

[FIX] payment: Pay button always enabled with Term & Conditions

2020-08-12T14:32:16+00:00

Steps to reproduce:

- Go to the website shop
- Add a product in the cart
- Add your address and click on checkout
- On the checkout, enable Terms & conditions

Bug:

The button was always enabled even if the check box with the terms & conditions were not
checked.

opw:2313437

closes odoo/odoo#55821

X-original-commit: 0415da51960819ec9c989e15a9229bd6d583ba1b
Signed-off-by: Simon Goffin (sig)

[FIX] payment: fix portal can click pay when js not loaded

2020-07-06T11:30:29+00:00

Issue

	- Go to Accounting / Customers / Invoices
	- Pick any invoice not paid
	- Action: Generate a Payment Link
	- Open the link
	- Refresh the page having Javascript disabled
	- Click the Pay Now button

	Traceback

Cause

	If JS is not loaded, the values in the form fields are
	not bound as expected.

	It can also happen with slow connections and fast click
	on the button at the loading. Before the JS is entirely
	loaded (as it is lazy-loaded).

Solution

	Button disabled by default, wait the page to be loaded
	and then activate the button

OPW-2255760

closes odoo/odoo#54128

X-original-commit: 0e7071f249e69c5cca519ec66120530eb0f97153
Signed-off-by: Jason Van Malder (jvm)

[FIX] payment: fix ecommerce blinking "Pay now" button

2019-12-16T07:14:13+00:00

Issue

    - Install e-commerce
    - Add stripe as payment acquirer
    - Go in website > shop
    - Add something in your cart and process checkout
    - In developer tools > network set online to slow 3g
    - Spam the pay now button
    - Go in Website > Configuration > Ecommerce > Payment Transactions

    Multiple transactions have been created for your order.

Cause

    The pay now button doesn't stay disabled during the payment process.

Solution

    Disable the button and enable it only when the process is done.

OPW-2148899

closes odoo/odoo#41910

X-original-commit: 76a0e4fea0d9a15b3d193e00dd473c4488d18640
Signed-off-by: Jason Van Malder