Odoo/addons/mail/tests/common.py, branch 14.0 The current checkout of upstream Odoo [IMP] test_mass_mailing: add tests for replies to mailings depending on update mode 2021-04-27T09:15:43+00:00 Thibault Delavallée tde@odoo.com 2021-04-26T12:38:49+00:00 d08942c3ab80a8f573d38c02e8e8a10a1ede5433 Purpose of this commit is to add tests related to answers through mail gateway when having reply-to mode of mailing set to either updating existing threads (aka replying on mailed records), either creating new threads (aka using the reply-to alias configuration). Backport of odoo/odoo@4ef24369c813ec6a6ce997369aa454d9d67a992b done in master (14.4) LINKS Task ID-2117639 COM PR odoo/odoo#40931 
Purpose of this commit is to add tests related to answers through mail gateway
when having reply-to mode of mailing set to either updating existing threads
(aka replying on mailed records), either creating new threads (aka using the
reply-to alias configuration).

Backport of odoo/odoo@4ef24369c813ec6a6ce997369aa454d9d67a992b done in master (14.4)

LINKS

Task ID-2117639
COM PR odoo/odoo#40931
 [IMP] mail, (test)_mass_mailing, test_mail_full: improve email-based mailing tests 2021-04-19T14:07:49+00:00 Thibault Delavallée tde@odoo.com 2021-04-16T11:50:17+00:00 7aceb76c277b8b18d0315b5acf3645ab20528380 PURPOSE Purpose is to have more tests when sending mail mailings, notably about canceled or failed mails or sms as well as jinja and links rendering. SPECIFICATIONS In this commit we improve Email Marketing mailing tests. We notably * add tests for void and invalid email and numbers. It allows to check they correctly update their trace status; * add tests for unsubscribe and view links embedded in mass mailing emails; * add tests to simulate a click on links sent through mass mailing and ensure click statistics are effectively updated; * add tests to simulate bounce emails coming back to the mail gateway; Default content of mailings used in test is updated to ensure jinja is correctly rendered, including links and some corner cases. This will also helps ensuring behavior is kept when converting to QWeb. Various docstrings are added to helpers and custom asserts. LINKS Task ID-2508643 Followup of odoo/odoo#68874 (improve mail tests) Prepares Task ID-27033 (support QWeb in templates) Prepares Task ID-2377974 (clean trace and status management in mass mailing) COM PR odoo/odoo#69461 ENT PR odoo/enterprise#17780 
PURPOSE

Purpose is to have more tests when sending mail mailings, notably about
canceled or failed mails or sms as well as jinja and links rendering.

SPECIFICATIONS

In this commit we improve Email Marketing mailing tests. We notably

  * add tests for void and invalid email and numbers. It allows to check they
    correctly update their trace status;
  * add tests for unsubscribe and view links embedded in mass mailing emails;
  * add tests to simulate a click on links sent through mass mailing and
    ensure click statistics are effectively updated;
  * add tests to simulate bounce emails coming back to the mail gateway;

Default content of mailings used in test is updated to ensure jinja is
correctly rendered, including links and some corner cases. This will also
helps ensuring behavior is kept when converting to QWeb.

Various docstrings are added to helpers and custom asserts.

LINKS

Task ID-2508643
Followup of odoo/odoo#68874 (improve mail tests)
Prepares Task ID-27033 (support QWeb in templates)
Prepares Task ID-2377974 (clean trace and status management in mass mailing)
COM PR odoo/odoo#69461
ENT PR odoo/enterprise#17780
 [IMP] mail, (test_)mass_mailing: also check sent emails if possible 2021-04-08T15:06:28+00:00 Thibault Delavallée tde@odoo.com 2021-04-08T14:41:56+00:00 cb648d20dfe949c71c1f50ebda822d32ec8c976f When using assertMailMailWEmails custom assert we now check that a sent mail.mail matches a sent email. It allows to have a complete check from mailing traces to sent emails. Task ID-2500615 COM PR odoo/odoo#68874 ENT PR odoo/enterprise#17558 
When using assertMailMailWEmails custom assert we now check that a sent
mail.mail matches a sent email. It allows to have a complete check from
mailing traces to sent emails.

Task ID-2500615
COM PR odoo/odoo#68874
ENT PR odoo/enterprise#17558
 [IMP] event, mail, mass_mailing, sms, test_mail: clean some mail tests tools helpers and parameters 2021-04-08T15:06:12+00:00 Thibault Delavallée tde@odoo.com 2021-04-07T09:17:19+00:00 c75e8619663efc4d97ab13fb35f815104239dd36 In this commit we backport some of 14.1+ improvements done in mail tools in order to keep a coherent definition through sub versions. We also improve docstring and add some explanations on available toold and asserts. Task ID-2500615 COM PR odoo/odoo#68874 
In this commit we backport some of 14.1+ improvements done in mail tools
in order to keep a coherent definition through sub versions. We also
improve docstring and add some explanations on available toold and asserts.

Task ID-2500615
COM PR odoo/odoo#68874
 [MOV] mail, test_mail: merge and improve composer tests 2021-04-08T15:06:04+00:00 Thibault Delavallée tde@odoo.com 2021-04-07T10:09:45+00:00 51700491ae3b26d513ddfeda378a60592fca6eab This commits is a bit a followup of odoo/odoo#62061 where new composer tests were added. This commit finalize this work by merging all composer related tests within the same file. It also backports some of tooling update done in odoo/odoo#64459 or odoo/odoo#63677 in order to have coherent naming through 14+ versions. Some additional or deeper tests are added. Notably it now more cleanly uses asserts for created mail.mail and sent emails. Task ID-2500615 COM PR odoo/odoo#68874 
This commits is a bit a followup of odoo/odoo#62061 where new composer tests
were added. This commit finalize this work by merging all composer related
tests within the same file. It also backports some of tooling update done
in odoo/odoo#64459 or odoo/odoo#63677 in order to have coherent naming
through 14+ versions.

Some additional or deeper tests are added. Notably it now more cleanly
uses asserts for created mail.mail and sent emails.

Task ID-2500615
COM PR odoo/odoo#68874
 [IMP] event: improve tests about communication scheduling 2021-03-19T16:36:20+00:00 Thibault Delavallée tde@odoo.com 2021-03-19T13:31:59+00:00 1a66d9cb57dc17b697b7a56effa91de3a4b50bd7 In this commit we improve event communication scheduling tests. We make tests more detailed and use mail tools to ensure content. We also check scheduled dates and use freezegun to ease date management. Related to Task ID-2414658 COM PR odoo/odoo#68158 
In this commit we improve event communication scheduling tests. We make tests
more detailed and use mail tools to ensure content. We also check scheduled
dates and use freezegun to ease date management.

Related to Task ID-2414658
COM PR odoo/odoo#68158
 [FIX] mail: missing flush() in test class mixin 2021-02-16T12:36:26+00:00 Raphael Collet rco@odoo.com 2021-02-16T12:34:59+00:00 1c665d2f095978976be41c0c1c6513a876c30145 This SavepointCase mixin is combined with a TransactionCase mixin, which is not ideal. Adding an explicit flush() in the SavepointCase avoids an infinite loop in a child test class (TestServerActionsEmail). 
This SavepointCase mixin is combined with a TransactionCase mixin, which
is not ideal.  Adding an explicit flush() in the SavepointCase avoids an
infinite loop in a child test class (TestServerActionsEmail).
 [FIX] mail: send notification mail with right access link when using mail.thread 2021-01-06T17:03:53+00:00 Achraf (abz) abz@odoo.com 2020-10-23T06:47:54+00:00 79f27f640ccdd14f285a9dd9fc0ae770c992376f PURPOSE Notification may be sent using a generic mail.thread record, notably when sending user notifications. In that case links to view document are incorrect. HOW TO REPRODUCE Issue - Install "Approvals" - Submit new approval with you as "Request Owner" - Click on "View Approval Request" in your mailbox The link redirects to a 505 error Cause The model is not the correct one and the res_id is undefined Solution Specify the model and the res_id to _notify_get_action_link when creating the link with kwargs SPECIFICATIONS Propagate message value through various notification sub methods. That way we can rely on them if model seems void. Also limit values given as URL parameters to some white listed values. LINKS opw-2358846 Task ID-2379766 Followup of odoo/odoo#60998 Followup of odoo/odoo#61545 Closes odoo/odoo#63292 Closes odoo/enterprise#15585 closes odoo/odoo#64170 X-original-commit: 2b6d2b71f6c60bcf64db440473c88d1dc335acbf Related: odoo/enterprise#15588 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Co-authored-by: Achraf Ben Azzouz <abz@odoo.com> Co-authored-by: Thibault Delavallée <tde@odoo.com> 
PURPOSE

Notification may be sent using a generic mail.thread record, notably when
sending user notifications. In that case links to view document are
incorrect.

HOW TO REPRODUCE

Issue

    - Install "Approvals"
    - Submit new approval with you as "Request Owner"
    - Click on "View Approval Request" in your mailbox

    The link redirects to a 505 error

Cause

    The model is not the correct one and the res_id is undefined

Solution

    Specify the model and the res_id to _notify_get_action_link
    when creating the link with kwargs

SPECIFICATIONS

Propagate message value through various notification sub methods. That way
we can rely on them if model seems void.

Also limit values given as URL parameters to some white listed values.

LINKS

opw-2358846
Task ID-2379766
Followup of odoo/odoo#60998
Followup of odoo/odoo#61545
Closes odoo/odoo#63292
Closes odoo/enterprise#15585

closes odoo/odoo#64170

X-original-commit: 2b6d2b71f6c60bcf64db440473c88d1dc335acbf
Related: odoo/enterprise#15588
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Achraf Ben Azzouz <abz@odoo.com>
Co-authored-by: Thibault Delavallée <tde@odoo.com>
[FIX] core: cursor hooks API and implementation 2020-09-03T09:05:21+00:00 Raphael Collet rco@odoo.com 2020-08-28T14:11:21+00:00 d4b2e9224839aed8fc160ebe5a89e0f7d4c6a5bb Python 3.8 changed the equality rules for bound methods to be based on the *identity* of the receiver (`__self__`) rather than its *equality*. This means that in 3.7, methods from different instances will compare (and hash) equal, thereby landing in the same map "slot", but that isn't the case in 3.8. While it's usually not relevant, it's an issue for `GroupCalls` which is indexed by a function: in 3.7, that being a method from recordsets comparing equal will deduplicate them, but not anymore in 3.8, leading to duplicated callbacks (exactly the thing GroupCalls aims to avoid). Also, the API of `GroupCalls` turned out to be unusual and weird. The bug above is fixed by using a plain list for callbacks, thereby avoiding comparisons between registered functions. The API is now: callbacks.add(func) # add func to callbacks callbacks.run() # run all callbacks in addition order callbacks.clear() # remove all callbacks In order to handle aggregated data, the `callbacks` object provides a dictionary `callbacks.data` that any callback function can freely use. For the sake of consistency, the `callbacks.data` dict is automatically cleared upon execution of callbacks. Discovered by @william-andre Related to odoo#56583 References: * https://bugs.python.org/issue1617161 * python/cpython#7848 * https://docs.python.org/3/whatsnew/changelog.html#python-3-8-0-alpha-1 (no direct link because individual entries are not linkable, look for bpo-1617161) X-original-commit: a986f4929bab95759086cc77ca5e60795f82e91a 
Python 3.8 changed the equality rules for bound methods to be based on
the *identity* of the receiver (`__self__`) rather than its *equality*.
This means that in 3.7, methods from different instances will compare
(and hash) equal, thereby landing in the same map "slot", but that isn't
the case in 3.8.

While it's usually not relevant, it's an issue for `GroupCalls` which is
indexed by a function: in 3.7, that being a method from recordsets
comparing equal will deduplicate them, but not anymore in 3.8, leading
to duplicated callbacks (exactly the thing GroupCalls aims to avoid).

Also, the API of `GroupCalls` turned out to be unusual and weird.  The
bug above is fixed by using a plain list for callbacks, thereby avoiding
comparisons between registered functions.  The API is now:

    callbacks.add(func)     # add func to callbacks
    callbacks.run()         # run all callbacks in addition order
    callbacks.clear()       # remove all callbacks

In order to handle aggregated data, the `callbacks` object provides a
dictionary `callbacks.data` that any callback function can freely use.
For the sake of consistency, the `callbacks.data` dict is automatically
cleared upon execution of callbacks.

Discovered by @william-andre

Related to odoo#56583

References:

* https://bugs.python.org/issue1617161
* python/cpython#7848
* https://docs.python.org/3/whatsnew/changelog.html#python-3-8-0-alpha-1
  (no direct link because individual entries are not linkable, look for
  bpo-1617161)

X-original-commit: a986f4929bab95759086cc77ca5e60795f82e91a
 [IMP] test_mail_full: add mass_mailing test, notably for preview / browser view 2020-08-05T13:55:04+00:00 Thibault Delavallée tde@odoo.com 2020-08-05T10:02:23+00:00 cfbbc229d88b74ec7080c47cf1b6555dfc3c23b4 Purpose of this commit is to add some mass mailing tests in test mail full (with all community mailing capabilities installed). In this commit we notably tests unsubscribe and view URLs computation in sent emails, as well as the invisible preview block for email clients. Task ID-2239327 Task ID-2239327 PR #49886 Related: odoo/enterprise#10091 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> 
Purpose of this commit is to add some mass mailing tests in test mail full
(with all community mailing capabilities installed). In this commit we notably
tests unsubscribe and view URLs computation in sent emails, as well as
the invisible preview block for email clients.

Task ID-2239327
Task ID-2239327
PR #49886

Related: odoo/enterprise#10091
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>