Odoo/addons/hr_holidays/models, branch 14.0 The current checkout of upstream Odoo [WIP] hr_holidays: Leaves for partial time are wrongly counted 2021-05-04T15:24:08+00:00 Goffin Simon sig@odoo.com 2021-04-08T12:56:13+00:00 f964b761eae32016e36dd9d39cc2c35fc2270eba Steps to reproduce the bug: - Let's consider an employee E that doesn't work on Monday morning - Create a half day leave request LR for E on a Monday afternoon - Save Bug: The duration of LR was counted as one day instead of 0.5 opw:2491784 closes odoo/odoo#68977 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> 
Steps to reproduce the bug:

- Let's consider an employee E that doesn't work on Monday morning
- Create a half day leave request LR for E on a Monday afternoon
- Save

Bug:

The duration of LR was counted as one day instead of 0.5

opw:2491784

closes odoo/odoo#68977

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
[FW][FIX] mail, various: fix document access link computation 2021-04-23T08:00:43+00:00 Thibault Delavallée tde@odoo.com 2021-04-21T11:57:13+00:00 206685760abbc725765a1f4a5002c2a90abc0af8 Purpose of this commit is to fix computation of access link. In some cases msg_vals modification leads to invalid URL computation, notably for frontend or backend differentiation for target recipients. Followup of odoo/odoo#63292 . Task ID-2513724 COM PR odoo/odoo#69607 ENT PR odoo/enterprise#17849 X-Original-Commit: odoo/odoo@2015ef463c9ac7c7f89d543745c02a2d1528acf2 
Purpose of this commit is to fix computation of access link. In some cases
msg_vals modification leads to invalid URL computation, notably for frontend
or backend differentiation for target recipients.

Followup of odoo/odoo#63292 .

Task ID-2513724
COM PR odoo/odoo#69607
ENT PR odoo/enterprise#17849

X-Original-Commit: odoo/odoo@2015ef463c9ac7c7f89d543745c02a2d1528acf2
 [FIX] hr_holidays: Rounding allocation_used_count and allocation_count 2021-03-15T08:49:14+00:00 Goffin Simon sig@odoo.com 2021-02-24T14:05:07+00:00 af8ce1d8891a4dcdeb80b069a114299d84e021f1 Steps to reproduce the bug: - Let's consider an employee E with 8.00 hours as Average Hour per Day - Create an Allocation for E with a Time-off Type in Hours (be sure the number of hours is different from the average hour per Day) - Open the form view of E Bug: The smart button Time Off(remaining leaves) was completely unreadable opw:2441019 closes odoo/odoo#66830 X-original-commit: c5282b15f4a9a785cb2ca44c58ab28ec4ee5f7ca Signed-off-by: Simon Goffin (sig) <sig@openerp.com> 
Steps to reproduce the bug:

- Let's consider an employee E with 8.00 hours as Average Hour per Day
- Create an Allocation for E with a Time-off Type in Hours
(be sure the number of hours is different from the average hour per Day)
- Open the form view of E

Bug:

The smart button Time Off(remaining leaves) was completely unreadable

opw:2441019

closes odoo/odoo#66830

X-original-commit: c5282b15f4a9a785cb2ca44c58ab28ec4ee5f7ca
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
[FIX] hr_holidays: Initialize hr.employee.public view after hr.employee.public 2021-03-09T10:39:06+00:00 Kevin Baptiste kba@odoo.com 2021-03-04T16:01:00+00:00 2e225179bf3fb6ed98fa51f9fceca6f286a70b85 Purpose ====== Currently, in some rare cases, if the hr.employee.public is initialized before the hr.employee.public table, this could lead to a traceback or even some inconsistencies when computing the field current_leave_id, probably because of the MRO graph construction (to be investigated). Specification ========= 1/ Ensure the table existence 2/ Set a dummy value for current_leave_id to force the recomputation to a valid one. opw-2476677 closes odoo/odoo#67518 X-original-commit: 568ed9cde99bbcd6f3d390ec235c86c504466551 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> Signed-off-by: Kevin Baptiste <kba@odoo.com> 
Purpose
======

Currently, in some rare cases, if the hr.employee.public is initialized before the hr.employee.public
table, this could lead to a traceback or even some inconsistencies when computing the field
current_leave_id, probably because of the MRO graph construction (to be investigated).

Specification
=========

1/ Ensure the table existence
2/ Set a dummy value for current_leave_id to force the recomputation to a valid one.

opw-2476677

closes odoo/odoo#67518

X-original-commit: 568ed9cde99bbcd6f3d390ec235c86c504466551
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>
[FIX] hr_holidays: Can not approve or validate time off 2021-02-18T15:19:15+00:00 tivisse yti@odoo.com 2021-02-18T15:10:50+00:00 2030ebe18804edc8d3a4eeb7986df9a7eaca7255 A leave manager should be able to approve a time off that already begun. opw:2447240 closes odoo/odoo#66481 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> Co-authored-by: simongoffin <sig@odoo.com> 
A leave manager should be able to approve a time off that already begun.

opw:2447240

closes odoo/odoo#66481

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: simongoffin <sig@odoo.com>
[FIX] hr_holidays: Delete Time-Off request for own user/employee 2021-02-15T11:32:22+00:00 Goffin Simon sig@odoo.com 2021-02-11T15:31:01+00:00 225550cd376da1a0dbafda4fb2a037825ec92b10 Steps to reproducr the bug: - Let's consider an internal user U with no right in hr - Let's consider an employee E linked to U - Log with U - Create a hr.leave H with hr validation - Reset H to draft - Delete H Bug: An access right error was raised. opw:2443366 closes odoo/odoo#65993 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> 
Steps to reproducr the bug:

- Let's consider an internal user U with no right in hr
- Let's consider an employee E linked to U
- Log with U
- Create a hr.leave H with hr validation
- Reset H to draft
- Delete H

Bug:

An access right error was raised.

opw:2443366

closes odoo/odoo#65993

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
[FIX] hr_holidays: Display correct number of days 2021-02-09T15:21:44+00:00 Nasreddin (bon) bon@odoo.com 2021-02-09T15:09:44+00:00 1ec4aa0b61777739d8bc82bbee968b9838f58410 Issue - Install `Time Off` module - Go to `Time Off` and switch to month calendar view (default view) - Select range of date In wizard, `duration` is not set. Cause `date_to` and `date_from` are overided on default get request. Solution Do not override default value of `date_from` and `date_to` if provided in default get request. opw-2447931 closes odoo/odoo#65830 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> 
Issue

	- Install `Time Off` module
	- Go to `Time Off` and switch to month calendar view (default view)
	- Select range of date

	In wizard, `duration` is not set.

Cause

	`date_to` and `date_from` are overided on default get request.

Solution

	Do not override default value of `date_from` and
	`date_to` if provided in default get request.

opw-2447931

closes odoo/odoo#65830

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
[FIX] hr_holidays: Impossible to delete a refused Time-Off request 2021-01-27T09:52:40+00:00 Goffin Simon sig@odoo.com 2021-01-26T16:58:04+00:00 e15dfad1090605b9599ac42bb69c1f1bcfc80ce5 Steps to reproduce the bug: -Create a time-Off request R1 for 27/01 -Refuse R1 -Create another Time-Off request R2 for the same date 27/01 -Set R1 in draft -Try to delete R1 Bug: A ValidationError was raised: You can not set 2 time off that overlaps on the same day for the same employee. opw:2447540 closes odoo/odoo#65077 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> 
Steps to reproduce the bug:

-Create a time-Off request R1 for 27/01
-Refuse R1
-Create another Time-Off request R2 for the same date 27/01
-Set R1 in draft
-Try to delete R1

Bug:

A ValidationError was raised:

You can not set 2 time off that overlaps on the same day for the same employee.

opw:2447540

closes odoo/odoo#65077

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
[FIX] mail: send notification mail with right access link when using mail.thread 2021-01-06T17:03:53+00:00 Achraf (abz) abz@odoo.com 2020-10-23T06:47:54+00:00 79f27f640ccdd14f285a9dd9fc0ae770c992376f PURPOSE Notification may be sent using a generic mail.thread record, notably when sending user notifications. In that case links to view document are incorrect. HOW TO REPRODUCE Issue - Install "Approvals" - Submit new approval with you as "Request Owner" - Click on "View Approval Request" in your mailbox The link redirects to a 505 error Cause The model is not the correct one and the res_id is undefined Solution Specify the model and the res_id to _notify_get_action_link when creating the link with kwargs SPECIFICATIONS Propagate message value through various notification sub methods. That way we can rely on them if model seems void. Also limit values given as URL parameters to some white listed values. LINKS opw-2358846 Task ID-2379766 Followup of odoo/odoo#60998 Followup of odoo/odoo#61545 Closes odoo/odoo#63292 Closes odoo/enterprise#15585 closes odoo/odoo#64170 X-original-commit: 2b6d2b71f6c60bcf64db440473c88d1dc335acbf Related: odoo/enterprise#15588 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Co-authored-by: Achraf Ben Azzouz <abz@odoo.com> Co-authored-by: Thibault Delavallée <tde@odoo.com> 
PURPOSE

Notification may be sent using a generic mail.thread record, notably when
sending user notifications. In that case links to view document are
incorrect.

HOW TO REPRODUCE

Issue

    - Install "Approvals"
    - Submit new approval with you as "Request Owner"
    - Click on "View Approval Request" in your mailbox

    The link redirects to a 505 error

Cause

    The model is not the correct one and the res_id is undefined

Solution

    Specify the model and the res_id to _notify_get_action_link
    when creating the link with kwargs

SPECIFICATIONS

Propagate message value through various notification sub methods. That way
we can rely on them if model seems void.

Also limit values given as URL parameters to some white listed values.

LINKS

opw-2358846
Task ID-2379766
Followup of odoo/odoo#60998
Followup of odoo/odoo#61545
Closes odoo/odoo#63292
Closes odoo/enterprise#15585

closes odoo/odoo#64170

X-original-commit: 2b6d2b71f6c60bcf64db440473c88d1dc335acbf
Related: odoo/enterprise#15588
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Achraf Ben Azzouz <abz@odoo.com>
Co-authored-by: Thibault Delavallée <tde@odoo.com>
[FIX] hr_holidays: untranslated 'Hours' in hr_leave 2020-12-29T08:25:05+00:00 nie nie@odoo.com 2020-12-29T08:25:05+00:00 09d1e18eb401990a14d850e07a55cff498b30ac5 This translates 'Hours' when displaying the number of unpaid hours. closes odoo/odoo#63821 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com> 
This translates 'Hours' when displaying the number of unpaid hours.

closes odoo/odoo#63821

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>