Steps to reproduce the bug: - Let's consider a delivery carrier DC with invoice policy = 'real' - Let's consider a consumable product P with a weight = 1kg and sales price = 10€ - Create a sale order SO with 2 P and add DC as shipping cost - Process the shipment for 1 P and create a backorder - Process the second shipment with the last P Bug: Two lines L1, L2 with DC were created on SO but only L1 as a price unit and a description. L2 had a price unit = 0€ and no description. opw:2520135 closes odoo/odoo#70454 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> Co-authored-by: simongoffin <sig@odoo.com>
If we're to change the invoice policy of a product we'd provoke a chained computation of every sale line and sale order containing such product. This change goes along with the policy of applying such changes only to future orders, as stated here: https://github.com/odoo/odoo/pull/61135 closes odoo/odoo#64634 X-original-commit: 806da3d67a5cf9919c6c0f5042b3e00c69825faa Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
A based on rules shipping method with the "Free if order amount is above" field enabled is not correctly applied. To reproduce the error: (Need website_sale) 1. Go to Settings > Website 2. Enable "Shipping Costs" 3. Go to Website > Configuration > eCommerce > Shipping Methods 4. Create a new one - Select "Based on Rules" - Enable "Free if order amount is above" - Set the corresponding amount - In pricing, add a line 5. Save & Publish (Click on "Unpublished") 6. Go to website's shop 7. Add the product set in the shipping method to your cart - Select an amount sufficient to exceed the threshold amount set in step 4 8. Process Checkout => The shipping method is shown, but the associated amount is "No price rule matching this order[...]" The shipping method price should be 0. (This error also happens when creating a SO) OPW-2383258 closes odoo/odoo#62288 X-original-commit: 393b7ad7b7dff1cbf830374c76ef0a681a71be6a Signed-off-by: adwid <adwid@users.noreply.github.com>
Fine-tune of #59524. If the delivery address doesn't have any delivery method assigned, you get an undesired change of behavior: no delivery method is populated in that cases. Note that the delivery method is not a commercial field that is propagated from parent to children. With this patch, we get a very similar behavior, which is fallbacking to the commercial partner's delivery method if there's no delivery method in the delivery address. The only different behavior will be if the order partner is different from the commercial partner of the delivery address. closes odoo/odoo#60879 X-original-commit: 682b2e6c214b73f67e849df927bd4bda0af31d5a Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Steps: * Create a delivery method (1) restricted to Spain (any country would do) * Create a delivery method (2) restricted to Madagascar (same) * Create a partner, main company, whose country is Spain and the default delivery method is the first one. * Create a delivery address for that customer with Madagascar as country and the default delivery method as the second one. * Now place a new quotation with such partner and set the delivery address to the one of Madagascar (multiple addresses setting must be on). Before: * The delivery method for the quotation is set to the one restricted to Spain although we're sending it to Madagascar. After: * The delivery method for the quotation is set to the one restricted to Madagascar. --- opw-2348336 closes odoo/odoo#59879 X-original-commit: 535d429960a0347d01c528c2440c2b8e9ff2fb51 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Issue - Ensure that the provider of "The Poste" delivery method is "Based on Rules". - Create a quotation with "The Poste" as shipping method. - Confirm, then click on "Delivery" stat button. - Click on "Put in Pack" and create a "Delivery Packaging". - Save, go back to quotation and duplicate it. - Confirm, then click on "Delivery" stat button. - Click on "Put in Pack". The "Delivery Packaging" created previously is not available. Solution If 'current_package_carrier_type' is equal to 'fixed' or 'base_on_rule', replace it by 'none' since there are the equivalents in 'package_carrier_type' for 'delivery_type'. Related fix : https://github.com/odoo/odoo/pull/37427 opw-2310258 closes odoo/odoo#57435 X-original-commit: 5898d31025eacad3e8c37f7a105e20c81831ed17 Signed-off-by: Simon Goffin (sig) <sig@openerp.com> Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
Use _for_xml_id to replace all the self.env.ref().read()[0] This has the advantage of having a single point of control and to add the fields filtering and model verification. Add sudo for other operations on ir.actions.*
When creating a new delivery method with a provider based on rules, if the base list_base_price was equal to x.8, that ended to a float with endless decimal. (eg: 2.8000000000003) This fix modify the display to show a rounded value. closes odoo/odoo#54177 Task-id: 2272472 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
This commit extends the delivery slip so that products added as a kit component to a stock.picking are grouped together by kit (or non-kit) when at least 1 kit exists. Kit grouping occurs for products from a kit without a package assigned. Non-kit section appears only when no packages are assigned. Implementation notes: - Sub-kits (i.e. kits within kits) of kits are purposely not included - Duplicate product names with different BOMs will be merged into one since there is no straightforward way to distinguish them within current db structure - There are some cases where this doesn't work as expected and may lead to components being grouped together under the same kit even if they are from different kits (e.g. kit1 has bolts and so does kit2 => on slip bolts will only show under kit1 section). Two cases where this happens is when kits are added before 'Operation Type' is specified and 'Operation Type = Manufacturing' This completes subsection 1 of overall Improve delivery slip task. Task: 2039720
This commit makes it so if a delivery slip contains 1 or more packages then move lines will be split by package (and non-package) groups with a "section line" between them. This only applies to when a stock.picking is 'State=Done'. In order to accomodate complexity of splitting by package + grouping by product unless printing serial numbers/lots + template inheritance, reoccurring parts of the template are split into their own templates and called. Relevant inheritance has been updated to match. Additionally, picking.shipping_weight calculation has been updated so if a pack.weight = 0 then calculation will default to the calculated product weight. This prevents inconsistency between the "Total Weight" at the top of the Delivery Slip and the package sections' displayed weights. To distinguish which value is being used, package sections that use the total product weight rather than the pack.weight have "(estimated)" after it. This completes subsection 3 of overall Improve delivery slip task. Task: 2039720