https://github.com/odoo/odoo/pull/68253 fixed a bug in check_vat that caused it not to run any check when called on a partner with no country. However, doing this caused another issue because of an ORM limitation: when writing vat and country_id with a single write() on the res.company, two distinct write are triggered on the related res.partner, one for each field. Both those write trigger the check_vat constraint. Depending on the order in which the keys of the dictionnary passed to res.company's write were ordered, country_id could or could not be written before vat. If vat was written first and did not start with a country code, the write() on res.partner failed the constraint, because country_id wasn't set yet. This was wrong, but used to pass as there was no country_id on the partner, before https://github.com/odoo/odoo/pull/68253 fixed that. To circumvent the issue, we now allow entering any vat number without performing any check if it does not start with a country code and no country_id is set on the partner. closes odoo/odoo#69034 X-original-commit: 3b73ea994a0eedc08ee0e7c43610ca5e78984b54 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com> Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Before this, when making a partner without any country_id, any VAT could be set to it, which was inconsistent with the module's purpose. closes odoo/odoo#68492 X-original-commit: 4c962437bd59a1e9302d8034e8870880994eb713 Related: odoo/enterprise#17358 Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com> Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Following Brexit on January 1st 2021, companies in Northern Ireland have a new VAT number starting with XI instead of GB. More info: https://www.gov.uk/government/publications/accounting-for-vat-on-goods-moving-between-great-britain-and-northern-ireland-from-1-january-2021/check-when-you-are-trading-under-the-northern-ireland-protocol-if-you-are-vat-registered-business stdnum support the new XI VAT from 1.16 https://github.com/arthurdejong/python-stdnum/commit/b93d69581f35aa18e7fdd52b3f7fdf06770215e3 This patch add temporary support in base_vat until the new version is available on the Debian package repository Community tracked issue https://github.com/odoo/odoo/issues/64891 opw-2461322 closes odoo/odoo#67402 X-original-commit: 049ea814283448e44e102969ffd08837f110e3ea Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
The function was wrongly imported and used, and it was hidden by a generic catching of all exceptions. The return value and some legit exceptions were also badly handled: * The return value was always thruthy as it returns an object containing information about the check. * Exceptions can be raised if the format is not correct. In that case, we don't want to go to the simple vat check. Fixes #64897 opw-2451951 closes odoo/odoo#65771 Signed-off-by: William André (wan) <wan@odoo.com>
The Australian equivalent of a VAT number is an ABN number. In Australia TFN are private and not meant to be entered into systems or publicly displayed. ABN numbers are the public facing number that legally must be displayed on all tax invoices and legal documents. This fix will override the 'tfn' check done via stdnum for AU companies with 'abn' check opw-2415142 closes odoo/odoo#64131 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
As described here: https://www.estv.admin.ch/estv/fr/home/mehrwertsteuer/fachinformationen/steuerpflicht/unternehmens-identifikationsnummer--uid-.html The "new" (since 2014) vat number has to be displayed as: CHE 9 numeric digits plus TVA/MWST/IVA e.g.: CHE-123.456.788 TVA This commit removes the previous 6 digits vat number check and regex, and provide accurate examples on the error message displayed if the vatnumber given is wrong. opw-2291581 closes odoo/odoo#59789 X-original-commit: 624e086f0c8ac854fd292d3c6dd14a71ed67b9fe Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
- Go to the Contacts app - Click on the Azure Interior company, or any other company with multiple associated people - Set the country to Mexico - Edit the VAT field and enter the following string: UAC070620MB3 Traceback will happen after hitting save. It happens because `self` is a recordset in this case. Moreover, while the VAT number starts with `UA`, the country is Mexico so the check is incorrct. opw-2348045 closes odoo/odoo#59257 X-original-commit: 3dbdc62b3458e9af2e74d8552a17d629dc7e2393 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
- removed simple check vat for columbia - removed document type field from partner - document type will be managed by latam type - updated city name for colombia - added data for for latam identification type - Added depdencies - base_address_city - account_debit_note - l10n_latam_base task- 2190843 closes odoo/odoo#53040 Related: odoo/upgrade#1589 Related: odoo/enterprise#9567 Signed-off-by: Josse Colpaert <jco@openerp.com>
- Install Contacts and Belgium - Accounting (l10n_be) - Go to Contacts and create a new Contact: * Select Switzerland as Country * Enter "CHE-123.456.788 TVA" ad VAT The VAT is auto-updated to "CHE123456788TVA", removing all special characters. The entered VAT is converted to its minimal representation, stripping whitespaces and seperators. And it is this compacted value that is stored. As defined here (https://www.estv.admin.ch/estv/fr/home/mehrwertsteuer/fachinformationen/steuerpflicht/unternehmens-identifikationsnummer--uid-.html), the Swiss VAT format should be CHE-XXX.XXX.XXX TVA. Therefore, the VAT will be automatically formated to the official format. opw-2291581 closes odoo/odoo#55582 X-original-commit: d75614e22f5b0b72e6bebd9cafba36fe32b9eb51 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
When more than one parameter is present in a message, it helps the translation to use named placeholder. This way, the order can be changed. It also helps the comprehension of the message.