When using the "Send & Print" functionality, if the user adds an attachment, the latter won't be linked to the record. To reproduce the error: 1. Open a posted invoice 2. Send & Print 3. Attach a file > Select a file on your device 4. Send the email Error: The invoice's PDF is added to record's attachments, but not the other file (from step 3). When the module selects the attachments that need to be linked to the invoice, it only keeps the ones currently linked to `mail.compose.message`: https://github.com/odoo/odoo/blob/6441ab71cb68648aa735057952bf757677a20ee3/addons/mail/models/mail_thread.py#L1719-L1725 This is correct when the user creates a message directly in the chatter. However, when the mail is created thanks to `Send & Print` functionality, the attachment is linked to `account.invoice.send`. Another flow have a similar issue: from invoices list, select few ones, Action > Send & Print: the generated PDF won't be attached to their invoice. In such a situation, here is the source of the problem: https://github.com/odoo/odoo/blob/05ad6c477f7da2a495e5baf5b4629323b9d11fa0/addons/mail/wizard/mail_compose_message.py#L363-L367 There isn't any information about the invoice, therefore it is not possible to linked the attachment to it. OPW-2438457 closes odoo/odoo#71425 X-original-commit: e87f599d4eb22250b628d650b9f59b54db8d043c Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
The value taken into account in the SQL for the calculation were wrong: - Not based on the state of the invoices (cancelled and draft were taken into account) - Had the tax included opw-2464004 feedback-2478356 closes odoo/odoo#70586 X-original-commit: fafea72843e25e0fee091ca935df61edb9133f6f Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
In https://github.com/odoo/odoo/pull/52529/commits/078a3a0f760ff24d02070a343f28d2249a8b5ba7#diff-c217a13a40a3cc27dc516b899793abecfac8cab9a42fed407d4776bcbc9de9a8R812 the way the percentage is calculated is changed. This implies that a reconciliation rule allowing a 90% matching amount will not allow to reconcile a 90$ bank statement with a 100$ invoice (as it will calculate the % as 88.89%, not meeting the required 90 %) After cited commit: invoice 200, bank statement 180: (|-180| - |20|) / |-180| * 100 = 88.89% invoice 200, bank statement 220: (|-220| - |-20|) / |-220| * 100 = 90.91% credit note 200, bank statement -180: (|180| - |-20|) / |180| * 100 = 88.89% credit note 200, bank statement -220: (|220| - |20|) / |220| * 100 = 90.91% Now: invoice 200, bank statement 180: 100 - |20| / |(-180 - 20)| * 100 = 90% invoice 200, bank statement 220: 100 - |-20| / |(-220 - -20)| * 100 = 90% credit note 200, bank statement -180: 100 - |-20| / |(180 - -20)| * 100 = 90% credit note 200, bank statement -220: 100 - |20| / |(220 - 20)| * 100 = 90% closes odoo/odoo#70948 Task: 2427089 Signed-off-by: William André (wan) <wan@odoo.com>
Original issue: Create a payment like follow: Payment type: receive money Partner type: customer Destination account: whatever receivable Amount: define an amount (i.e. 90.00) On Save, open the draft jounral entry created. Lower the liquidity or counterpart amount and add a writeoff Go back to the payment, change the amount and save. The journal entry writeoff will swap from debit to credit at every change made to the amount. This occur also when changing currency on the payment opw-2475223 Otherwise, this fix is not covering all cases: inbound with write-off in debit inbound with write-off in credit outbound with write-off in debit outbound with write-off in credit closes odoo/odoo#70807 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Before this commit: When there is too much records to post and it's take time more than 15 minutes then server was restarted. So scheduler action will do the process with the same records again and again. After this commit: post record in batch of 1000 opw-2451446 closes odoo/odoo#69738 X-original-commit: b87612d6fc8d9ec27a8cf0803369c90df00c5f57 Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: rrt-odoo <rrt-odoo@users.noreply.github.com>
before this commit: _adapt_parent_account_group or _adapt_parent_account_group call with multi-company record then raise singleton error after this commit: singleton error is fixed closes odoo/odoo#69323 Signed-off-by: William André (wan) <wan@odoo.com>
The deletion of `account.payment` were slowed down
because of the missing index
```
QUERY PLAN
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Delete on account_payment (cost=20.37..44.45 rows=10 width=34) (actual time=0.449..0.450 rows=0 loops=1)
-> Nested Loop (cost=20.37..44.45 rows=10 width=34) (actual time=0.383..0.404 rows=10 loops=1)
-> HashAggregate (cost=19.95..20.05 rows=10 width=32) (actual time=0.378..0.380 rows=10 loops=1)
Group Key: "ANY_subquery".id
Batches: 1 Memory Usage: 24kB
-> Subquery Scan on "ANY_subquery" (cost=0.42..19.92 rows=10 width=32) (actual time=0.035..0.371 rows=10 loops=1)
-> Limit (cost=0.42..19.82 rows=10 width=4) (actual time=0.032..0.365 rows=10 loops=1)
-> Nested Loop (cost=0.42..186848.76 rows=96312 width=4) (actual time=0.031..0.364 rows=10 loops=1)
-> Seq Scan on account_payment_pre_backup pay_backup (cost=0.00..14763.48 rows=277317 width=4) (actual time=0.015..0.086 rows=53 loops=1)
Filter: ((state)::text <> ALL ('{draft,cancelled}'::text[]))
Rows Removed by Filter: 166
-> Index Scan using account_payment_pkey on account_payment pay (cost=0.42..0.62 rows=1 width=4) (actual time=0.005..0.005 rows=0 loops=53)
Index Cond: (id = pay_backup.id)
Filter: (move_id IS NULL)
Rows Removed by Filter: 1
-> Index Scan using account_payment_pkey on account_payment (cost=0.42..2.44 rows=1 width=10) (actual time=0.002..0.002 rows=1 loops=10)
Index Cond: (id = "ANY_subquery".id)
Planning Time: 0.294 ms
Trigger for constraint account_move_line_payment_id_fkey: time=1.236 calls=10
Trigger for constraint account_payment_sale_order_rel_account_payment_id_fkey: time=0.195 calls=10
Trigger for constraint credit_token_payment_id_fkey: time=1.308 calls=10
Trigger for constraint payment_transaction_payment_id_fkey: time=0.288 calls=10
Trigger for constraint account_invoice_payment_rel_payment_id_fkey1: time=0.191 calls=10
Trigger for constraint account_move_payment_id_fkey: time=6015.799 calls=10
Trigger for constraint account_payment_account_bank_statement__account_payment_id_fkey: time=0.444 calls=10
Execution Time: 6019.988 ms
```
upg-12139
closes odoo/odoo#70712
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
It seems some ppl are sharing the same bank account accross multiple journals. issues: 2527148 2527994 2527894 ... closes odoo/odoo#70676 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Create a draft payment with payment type and 0 amount. Save. The payment type will be overwritten opw-2495461 closes odoo/odoo#70603 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Create a payment like follow: - Payment type: receive money - Partner type: customer - Destination account: whatever receivable - Amount: define an amount (i.e. 90.00) On Save, open the draft jounral entry created. Lower the liquidity or counterpart amount and add a writeoff Go back to the payment, change the amount and save. The journal entry writeoff will swap from debit to credit at every change made to the amount. This occur also when changing currency on the payment opw-2475223 closes odoo/odoo#70303 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>